(In reply to Magnus Melin [:mkmelin] from comment #2) > Comment on attachment 9192248 [details] [diff] [review] > 1681009-remove-nsIMutableArray-use-1.patch > > Review of attachment 9192248 [details] [diff] [review]: > ----------------------------------------------------------------- > > LGTM. The suite/ changes are kind of not needed but I guess doesn't hurt > either. > > ::: mailnews/base/src/VirtualFolderWrapper.jsm > @@ +28,5 @@ > > * @param aParentFolder The folder in which to create the search folder. > > * @param aSearchFolders A list of nsIMsgFolders that you want to use as the > > * sources for the virtual folder OR a string that is the already '|' > > * delimited list of folder URIs to use. > > + * @param {Array.<nsIMsgSearchTerms>} aSearchTerms - The search terms to > > @param {nsIMsgSearchTerms[]} > > ... I think is better. > > ::: mailnews/search/content/searchTerm.js > @@ +512,5 @@ > > } > > > > +/** > > + * Save the search terms from the UI back to the actual search terms. > > + * @param {Array.<nsIMsgSearchTerm>} searchTerms - Array of terms > > @param {nsIMsgSearchTerm[]}
Bug 1681009 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(oops - accidental comment)