Bug 1681955 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
The alternative, i.e.:
```diff
diff --git a/gfx/layers/apz/src/AsyncPanZoomController.cpp b/gfx/layers/apz/src/AsyncPanZoomController.cpp
--- a/gfx/layers/apz/src/AsyncPanZoomController.cpp
+++ b/gfx/layers/apz/src/AsyncPanZoomController.cpp
@@ -5277,6 +5277,7 @@ void AsyncPanZoomController::NotifyLayer
           aLayerMetrics.GetCompositionSizeWithoutDynamicToolbar());
       needToReclampScroll = true;
     }
+    Metrics().SetIsRootContent(aLayerMetrics.IsRootContent());
     Metrics().SetBoundingCompositionSize(
         aLayerMetrics.GetBoundingCompositionSize());
     Metrics().SetPresShellResolution(aLayerMetrics.GetPresShellResolution());
```
appears to be no kinder:
```
Assertion failure: mIsRootContent, at /mnt/usb/work/debug/mozilla-unified/gfx/layers/FrameMetrics.h:465
```
that is:
```c++
 464   const ParentLayerSize& GetCompositionSizeWithoutDynamicToolbar() const {
 465     MOZ_ASSERT(mIsRootContent);
 466     return mCompositionSizeWithoutDynamicToolbar;
 467   }
```
Revision 1 by
on 
The alternative strategy (i.e. ""Another option would be to just update mIsRootContent in the other branch (where we update the other fields)"):
```diff
diff --git a/gfx/layers/apz/src/AsyncPanZoomController.cpp b/gfx/layers/apz/src/AsyncPanZoomController.cpp
--- a/gfx/layers/apz/src/AsyncPanZoomController.cpp
+++ b/gfx/layers/apz/src/AsyncPanZoomController.cpp
@@ -5277,6 +5277,7 @@ void AsyncPanZoomController::NotifyLayer
           aLayerMetrics.GetCompositionSizeWithoutDynamicToolbar());
       needToReclampScroll = true;
     }
+    Metrics().SetIsRootContent(aLayerMetrics.IsRootContent());
     Metrics().SetBoundingCompositionSize(
         aLayerMetrics.GetBoundingCompositionSize());
     Metrics().SetPresShellResolution(aLayerMetrics.GetPresShellResolution());
```
appears to trip another assert:
```
Assertion failure: mIsRootContent, at /mnt/usb/work/debug/mozilla-unified/gfx/layers/FrameMetrics.h:465
```
that is:
```c++
 464   const ParentLayerSize& GetCompositionSizeWithoutDynamicToolbar() const {
 465     MOZ_ASSERT(mIsRootContent);
 466     return mCompositionSizeWithoutDynamicToolbar;
 467   }
```

Back to Bug 1681955 Comment 8