Bug 1682206 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Current PIP forwards video frames to both Main window and PIP window, though rendering to Main window is not rendered by showing pictureInPictureOverlay.

Compositor and WebRender have a capability to skip such hidden video rendering. But it adds extra cpu cost to Compositor/WebRender.

Then it could cause a problem like  Bug 1674775. For performance, it seems better to skip video frame forwarding at VideoSink during cloning video if possible.
Revision 1 by
on 
Current PIP forwards video frames to both Main window and PIP window, though rendering to Main window is not shown by showing pictureInPictureOverlay.

Compositor and WebRender have a capability to skip such hidden video rendering. But it adds extra cpu cost to Compositor/WebRender.

Then it could cause a problem like  Bug 1674775. For performance, it seems better to skip video frame forwarding at VideoSink during cloning video if possible.
Revision 2 by
on 
Current PIP forwards video frames to both Main window and PIP window, though rendering to Main window is not shown by showing pictureInPictureOverlay.
- https://searchfox.org/mozilla-central/rev/97dd1934d16cada69dbf68e9cda9e9a017459e9e/toolkit/content/widgets/videocontrols.js#1023
- https://searchfox.org/mozilla-central/rev/97dd1934d16cada69dbf68e9cda9e9a017459e9e/toolkit/content/widgets/videocontrols.js#3011

Compositor and WebRender have a capability to skip such hidden video rendering. But it adds extra cpu cost to Compositor/WebRender.

Then it could cause a problem like  Bug 1674775. For performance, it seems better to skip video frame forwarding at VideoSink during cloning video if possible.
Revision 3 by
on 
Current PIP forwards video frames to both Main window and PIP window, though rendering to Main window is not shown by showing pictureInPictureOverlay.
- https://searchfox.org/mozilla-central/rev/97dd1934d16cada69dbf68e9cda9e9a017459e9e/toolkit/content/widgets/videocontrols.js#1023
- https://searchfox.org/mozilla-central/rev/97dd1934d16cada69dbf68e9cda9e9a017459e9e/toolkit/content/widgets/videocontrols.js#3011

Compositor and WebRender have a capability to skip such hidden video rendering. But it adds extra cpu costs to Compositor/WebRender.

Then it could cause a problem like  Bug 1674775. For performance, it seems better to skip video frame forwarding at VideoSink during cloning video if possible.

Back to Bug 1682206 Comment 0