Bug 1682403 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The core issue in comment 3 seems to date back to Jan 2007 where these cocoa print-settings files were first added to the tree:
https://searchfox.org/mozilla-central/commit/5d473d4dc67b8e276d688a72a358a5646e9fe2bc

(It's probably older than that, since the commit message there is "copy printing impl to cocoa widgets")

Here's a highlighted version of the `ReadPrefs` function as of that point -- it shows basically the same problematic two-line sequence that I quoted in comment 3 (initializing by reading from prefs, and then stomping on that values with a different data-reading function-call):
https://searchfox.org/mozilla-central/rev/5d473d4dc67b8e276d688a72a358a5646e9fe2bc/widget/src/cocoa/nsPrintOptionsX.mm#112,118
The core issue in comment 3 seems to date back to Jan 2007 where these cocoa print-settings files were first added to the tree:
https://searchfox.org/mozilla-central/commit/5d473d4dc67b8e276d688a72a358a5646e9fe2bc

(It's probably older than that, since the commit message there is "copy printing impl to cocoa widgets")

Here's a highlighted version of the `ReadPrefs` function as of that point -- it shows basically the same problematic two-line sequence that I quoted in comment 3 (initializing by reading from prefs, and then stomping on the just-read values with a different data-reading function-call, effectively disregarding some of the prefs):
https://searchfox.org/mozilla-central/rev/5d473d4dc67b8e276d688a72a358a5646e9fe2bc/widget/src/cocoa/nsPrintOptionsX.mm#112,118

Back to Bug 1682403 Comment 4