(In reply to Henri Sivonen (:hsivonen) from comment #34) > The failures are in a part of the test that (before the attempt to work around this failure) were not changed by the patch on the test side and were at least not supposed to be changed by the patch on the browser UI side. Also, the failures are clearly intermittent, because they didn't happen on the landing itself but on a later run. Well, the TV jobs were orange on the initial push. :-) > Gijs, do you have ideas of what goes wrong and what the action should be? The test indicates that the button should be disabled initially but isn't, so the question is... what *should* be disabling the button, and is that not happening, or is something else untowards happening that then re-enables it, before we check? Adding logging to your patch and pushing to try (if you can't reproduce locally with `--verify`) should help elucidate.
Bug 1687635 Comment 35 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Henri Sivonen (:hsivonen) from comment #34) > The failures are in a part of the test that (before the attempt to work around this failure) were not changed by the patch on the test side and were at least not supposed to be changed by the patch on the browser UI side. Also, the failures are clearly intermittent, because they didn't happen on the landing itself but on a later run. Well, the TV jobs were orange on the initial push. :-) > Gijs, do you have ideas of what goes wrong and what the action should be? The test indicates that the button should be disabled initially but isn't, so the question is... what *should* be disabling the button, and is that not happening, or is something else untowards happening that then re-enables it, before we check? Adding logging to your patch and pushing to try (if you can't reproduce locally with `--verify`) should help elucidate. I left some more notes on phabricator.