Bug 1689434 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
the number of `toJSAtom` call (including `getExistingAtomAt`) for length-3/4, for gmail_combined.js

|                             | well-known atom (no atomize) | hashmap cache hit | atomize + cache | total |
|-----------------------------|-----|-------|------|-------|
| parse_full : length-3       |   0 |     0 |    0 |     0 |
| parse_full : length-4       |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-3 |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-4 |   0 |     0 |    0 |     0 |
| compile_full : length-3     | 137 | 19699 | 9241 | 29077 |
| compile_full : length-4     |  98 |     0 | 1030 |  1128 |
| decode_full : length-3      | 137 | 19686 | 9241 | 29064 |
| decode_full : length-4      |  98 |     0 | 1033 |  1131 |

maybe better look into optimizing cache for length-3, and remove it for length-4.
Revision 1 by
on 
the number of `toJSAtom` call (including `getExistingAtomAt`) for length-3/4, for gmail_combined.js

|                             | well-known atom (no atomize) | hashmap cache hit | atomize + cache | total |
|-----------------------------|-----|-------|------|-------|
| parse_full : length-3       |   0 |     0 |    0 |     0 |
| parse_full : length-4       |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-3 |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-4 |   0 |     0 |    0 |     0 |
| compile_full : length-3     | 137 | 19699 | 9241 | 29077 |
| compile_full : length-4     |  98 |     0 | 1030 |  1128 |
| decode_full : length-3      | 137 | 19686 | 9241 | 29064 |
| decode_full : length-4      |  98 |     0 | 1033 |  1131 |

~~maybe better look into optimizing cache for length-3, and remove it for length-4.~~

(edit: the code was buggy that length-4 didn't cache the atom after instantiate. will fix and re-run the bench)
Revision 2 by
on 
(updated the result for length-4, after fixing the cache for length-4 atom)

the number of `toJSAtom` call (including `getExistingAtomAt`) for length-3/4, for gmail_combined.js

|                             | well-known atom (no atomize) | hashmap cache hit | atomize + cache | total |
|-----------------------------|-----|-------|------|-------|
| parse_full : length-3       |   0 |     0 |    0 |     0 |
| parse_full : length-4       |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-3 |   0 |     0 |    0 |     0 |
| dumpStencil_full : length-4 |   0 |     0 |    0 |     0 |
| compile_full : length-3     | 137 | 19699 | 9241 | 29077 |
| compile_full : length-4     |  98 |   475 |  555 |  1128 |
| decode_full : length-3      | 137 | 19686 | 9241 | 29064 |
| decode_full : length-4      |  98 |  478 | 555 |  1131 |

Back to Bug 1689434 Comment 6