Bug 1690093 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Klaus B. from comment #3)
> Uff, a patch with three lines context, that's impossible to look at. Please set 
> ```
> [diff]
> git = 1
> showfunc = 1
> unified = 8
> ```
> in your mercurial.ini. There's really not enough context, I'd have to pull out the file.

Don't know what "Uff" means but it sounds unpleasant :).  
Yeah, sorry about that. I forgot to update default hgrc with that on this new computer. (I guess it wasn't a problem with the other diffs you've looked at with the same hgrc.) 

I've requested info on this from Ben Bucksch regarding the this area of the code.
(In reply to Klaus B. from comment #3)
> Uff, a patch with three lines context, that's impossible to look at. Please set 
> ```
> [diff]
> git = 1
> showfunc = 1
> unified = 8
> ```
> in your mercurial.ini. There's really not enough context, I'd have to pull out the file.

Don't know what "Uff" means but it sounds unpleasant :).  
Yeah, sorry about that. I forgot to update default hgrc with that on this new computer. (I guess it wasn't a problem with the other diffs you've looked at with the same hgrc.) 

I've requested info on this from Ben Bucksch regarding this area of the code.
(In reply to Klaus B. from comment #3)
> Uff, a patch with three lines context, that's impossible to look at. Please set 
> ```
> [diff]
> git = 1
> showfunc = 1
> unified = 8
> ```
> in your mercurial.ini. There's really not enough context, I'd have to pull out the file.

Don't know what "Uff" means but it sounds unpleasant :).  
Yeah, sorry about that. I forgot to update default hgrc with that on this new computer. (I guess it wasn't a problem with the other diffs you've looked at with the same hgrc.) 

I've requested info on this from Ben Bucksch regarding this area of the code from 11 years ago.

Edit: Yes, I know "biff" just means checking for new mail every X minutes and producing a notification. Just not sure why the NS_ENSURE_TRUE is present and marked with comment "biff case", and when msgWindow is false/null, GetPassword() returns an error and causes a complete server disconnect. And not sure what a msgWindow even is and why some URLs have one ("select") while others don't (ensureExists).

Back to Bug 1690093 Comment 5