Bug 1691095 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The macros in [ProfilingCategoryList.h](https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/public/ProfilingCategoryList.h) currently use strings for the category color. However, only a fixed list of color names is available - that's because we want the front-end to pick the actual color value based on the devtools color palette.
It's easy to miss the fact that only certain values are allowed, and the color names look like CSS names. It would be better to use an enum so that these mistakes can be avoided.
The macros in [ProfilingCategoryList.h](https://searchfox.org/mozilla-central/source/mozglue/baseprofiler/public/ProfilingCategoryList.h) currently use strings for the category color. However, only a fixed list of color names is available - that's because we want the front-end to pick the actual color value based on the devtools color palette.
It's easy to miss the fact that only certain values are allowed, and the color names look like CSS color names. It would be better to use an enum so that these mistakes can be avoided.

Back to Bug 1691095 Comment 0