Bug 1692132 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

[pkix_CacheCert_Lookup](https://searchfox.org/mozilla-central/rev/04f921656dfd19a5afa503c9b9780a1a389f14c4/security/nss/lib/libpkix/pkix/util/pkix_tools.c#923) doesn't return a result when there's a cache hit: `*pFound` is set to `PKIX_FALSE` at the outset, then only set (again) to false. We still maintain the table and evict old entries, but since `*pFound` is never true, the result isn't returned. This is at odds with the function description.

We might just need to set `*pFound` near the point at which `selCertList` is appended to, but I haven't tested this.
[pkix_CacheCert_Lookup](https://searchfox.org/mozilla-central/rev/04f921656dfd19a5afa503c9b9780a1a389f14c4/security/nss/lib/libpkix/pkix/util/pkix_tools.c#923) doesn't return a result when there's a cache hit: `*pFound` is set to `PKIX_FALSE` at the outset, then only set (again) to false. We still maintain the table and evict old entries, but since `*pFound` is never true, the result isn't returned. This is at odds with the function description.

We might just need to set `*pFound` near the point at which `selCertList` is appended to, but I haven't tested this. 

(this was originally noted in bug 1682044)

Back to Bug 1692132 Comment 0