Bug 1692980 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
okay, there are two problems:
1. [isVisible](https://searchfox.org/mozilla-central/rev/a8b75e4ba3f8ddf0e76b42681d0a7b7e78e67730/toolkit/modules/third_party/fathom/fathom.jsm#488) in fathom throws exception in xpcsehll-test because the element doesn't have a window
2. `isProbablyANewPassword` returns false for "confirmed password" in password change form (score is 0.73, slight lower than the current threshold holder 0.75). I'll check if that happens in other password change forms in our samples.
Revision 1 by
on 
okay, there are two problems:
1. [isVisible](https://searchfox.org/mozilla-central/rev/a8b75e4ba3f8ddf0e76b42681d0a7b7e78e67730/toolkit/modules/third_party/fathom/fathom.jsm#488) in fathom throws exception in xpcsehll-test because the element doesn't have a window
2. `isProbablyANewPassword` returns false for "confirmed password" in password change form (score is 0.73, slight lower than the current threshold holder 0.75). I'll check if that also happens in other password change forms in our samples.

Back to Bug 1692980 Comment 5