Bug 1693154 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
This is working now after some more UID and DL name fun. A few comments:
- nsAbOutlookDirectory::AddMailList() needed a complete rewrite.
- nsAbWinHelper::CreateEntry(), renamed to nsAbWinHelper::CreateEntryInternal() was good enough to create DLs as well with some tweaks.
- The DL name needs to be set via a named attribute whose tag we need to fetch.
- CopyEntry() and GetDefaultContainer() are obsolete now.
- Some boy-scout cleanup: Renamed a few badly names variables, inlined UpdateAddressList().
Revision 1 by
on 
This is working now after some more UID and DL name fun. A few comments:
- nsAbOutlookDirectory::AddMailList() needed a complete rewrite.
- nsAbWinHelper::CreateEntry(), renamed to nsAbWinHelper::CreateEntryInternal() was good enough to create DLs as well with some tweaks.
- The DL name needs to be set via a named attribute whose tag we need to fetch.
- CopyEntry() and GetDefaultContainer() are obsolete now.
- Some boy-scout cleanup: Renamed a few badly named variables, inlined UpdateAddressList().

Back to Bug 1693154 Comment 11