Bug 1694237 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

A bit unrelated to this regression, but I'll note it here nevertheless: when transitioning through typing a history contained query string, we're going through two phases, which in my view might not hold less value than actually showing one more search suggestion. To elaborate, use the following:

STR:

1. Type "testing" in the urlbar or search-mode and press enter to do a search
2. Close the tab, open a new tab.
3. In the urlbar, type test
4. Continue typing +ing
5. Continue typing  adding a space.

AR:
3. [testing shown as history suggestion](https://drive.google.com/file/d/1KlOo6aLj0hjXQqSGGlwpL1nm6RacFqBq/view?usp=sharing)
4. [testing shown as search term - no history icon](https://drive.google.com/file/d/1PSOo57e2jQx_TUepeiq256YnXogk5u1-/view?usp=sharing)
5. [both search suggestion and search term](https://drive.google.com/file/d/17ydOHehm-Iue5PFyt0ZJHJ-HCktnL9IY/view?usp=sharing)

In my view, both step 4 and step 5 results should show only one entry for testing, and in the case in which there is search history mark it as such. It would be arguable that there is a need to mark that this is a google search or whatever the default engine might be, but when you consider the search-mode now, it just seems a redundant detail + ocupying a needesly search suggestion spot.
A bit unrelated to this regression, but I'll note it here nevertheless: when transitioning through typing a history contained query string, we're going through two phases, which in my view might hold less value than actually showing one more search suggestion. To elaborate, use the following:

STR:

1. Type "testing" in the urlbar or search-mode and press enter to do a search
2. Close the tab, open a new tab.
3. In the urlbar, type test
4. Continue typing +ing
5. Continue typing  adding a space.

AR:
3. [testing shown as history suggestion](https://drive.google.com/file/d/1KlOo6aLj0hjXQqSGGlwpL1nm6RacFqBq/view?usp=sharing)
4. [testing shown as search term - no history icon](https://drive.google.com/file/d/1PSOo57e2jQx_TUepeiq256YnXogk5u1-/view?usp=sharing)
5. [both search suggestion and search term](https://drive.google.com/file/d/17ydOHehm-Iue5PFyt0ZJHJ-HCktnL9IY/view?usp=sharing)

In my view, both step 4 and step 5 results should show only one entry for testing, and in the case in which there is search history mark it as such. It would be arguable that there is a need to mark that this is a google search or whatever the default engine might be, but when you consider the search-mode now, it just seems a redundant detail + ocupying a needesly search suggestion spot.
A bit unrelated to this regression, but I'll note it here nevertheless: when transitioning through typing a history contained query string, we're going through two phases, which in my view might hold less value than actually showing one more search suggestion. To elaborate, use the following:

STR:

1. Type "testing" in the urlbar or search-mode and press enter to do a search
2. Close the tab, open a new tab.
3. In the urlbar, type test
4. Continue typing +ing
5. Continue typing  adding a space.

AR:
3. [testing shown as history suggestion](https://drive.google.com/file/d/1KlOo6aLj0hjXQqSGGlwpL1nm6RacFqBq/view?usp=sharing)
4. [testing shown as search term - no history icon](https://drive.google.com/file/d/1PSOo57e2jQx_TUepeiq256YnXogk5u1-/view?usp=sharing)
5. [both search suggestion and search term](https://drive.google.com/file/d/17ydOHehm-Iue5PFyt0ZJHJ-HCktnL9IY/view?usp=sharing)

In my view, both step 4 and step 5 results should show only one entry for testing, and in the case in which there is search history mark it as such. It would be arguable that there is a need to mark that this is a google search or whatever the default engine might be, but when you consider the search-mode now, it just seems a redundant detail + ocupying needesly a search suggestion spot.

Back to Bug 1694237 Comment 12