Bug 1694526 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is a placeholder bug so that we don't forget about this once the Proton toolbar background colors are known.

At the moment, the tabs toolbar (titlebar) has the following background colors:
 - With Firefox theme "Default":
   - When using macOS Light Mode: Dark, with behind-window vibrancy
   - When using macOS Dark Mode: Very dark gray, no vibrancy
 - With Firefox theme "Light": Light, with behind-window vibrancy
 - With Firefox theme "Dark": Very dark gray, no vibrancy

The Proton mock-ups I've seen all have a light gray tab bar, so I'm assuming that the "default to dark titlebar despite macOS Light Mode" behavior will go away.
It would also be nice to simplify the logic above to:
 - "Default" Firefox theme + macOS Light Mode == "Light" Firefox theme: Light titlebar
 - "Default" Firefox theme + macOS Dark Mode == "Dark" Firefox theme: Dark titlebar

I also think it may be a good idea to revisit the use of behind-window vibrancy, to align better with native macOS apps. On macOS, there are different things you can do with a rectangle in the window:
 - Behind-window vibrancy: Native apps use this for sidebars and for menus and arrow panels. A blurred version of the content from behind the window is visible, with varying amounts of the desktop background image mixed in.
 - Within-window vibrancy: Used by the toolbar in some macOS apps. Shows a blurred version of scrolled content from the content area in the same window. Sometimes noticeable as a flicker in the toolbar during scrolling. 
 - Desktop Tinting (new in macOS Big Sur): Not a transparency effect, applied to toolbars and gray window backgrounds. Tints the background color with colors from the desktop background image. Can be disabled in the macOS System Preferences.

I think we should use Desktop Tinting for the tabs toolbar on Big Sur. I don't have an opinion on what to use pre-Big Sur; Desktop Tinting is not available and within-window vibrancy would require more platform work that is out of scope for Proton. So we could either keep using behind-window vibrancy there or switch to a fully opaque solid color or gradient.
This is a placeholder bug so that we don't forget about this once the Proton toolbar background colors are known.

At the moment, the tabs toolbar (titlebar) has the following background colors:
 - With Firefox theme "Default":
   - When using macOS Light Mode: Dark, with behind-window vibrancy
   - When using macOS Dark Mode: Very dark gray, no vibrancy
 - With Firefox theme "Light": Light, with behind-window vibrancy
 - With Firefox theme "Dark": Very dark gray, no vibrancy

The Proton mock-ups I've seen all have a light gray tab bar, so I'm assuming that the "default to dark titlebar despite macOS Light Mode" behavior will go away.
It would also be nice to simplify the logic above to:
 - "Default" Firefox theme + macOS Light Mode == "Light" Firefox theme: Light titlebar
 - "Default" Firefox theme + macOS Dark Mode == "Dark" Firefox theme: Dark titlebar

I also think it may be a good idea to revisit the use of behind-window vibrancy, to align better with native macOS apps. On macOS, there are different things you can do with a rectangle in the window:
 - Behind-window vibrancy: Native apps use this for sidebars and for menus and arrow panels. A blurred version of the content from behind the window is visible, with varying amounts of the desktop background image mixed in.
 - Within-window vibrancy: Used by the toolbar in some macOS apps. Shows a blurred version of scrolled content from the content area in the same window. Sometimes noticeable as a flicker in the toolbar during scrolling. 
 - Desktop Tinting (new in macOS Big Sur): Not a transparency effect. Applied to toolbars and gray window backgrounds, and also to the vibrancy effects above. Tints the background color with colors from the desktop background image. Can be disabled in the macOS System Preferences.

I think we should use Desktop Tinting for the tabs toolbar on Big Sur. I don't have an opinion on what to use pre-Big Sur; Desktop Tinting is not available and within-window vibrancy would require more platform work that is out of scope for Proton. So we could either keep using behind-window vibrancy there or switch to a fully opaque solid color or gradient.

Back to Bug 1694526 Comment 0