(In reply to aminomancer from comment #16) > @:mak but also it depends on the image, if the icon width is not set explicitly, some of the images get squashed a little bit depending on the window scaling. and setting 1.5px padding as a general rule doesn't seem wise, since it's rendered differently depending on the window scaling too. this doesn't look right for me at 150% on windows 10 for example. I'm at 125%, it's not exactly right for me too, but that's what the spec says. This is more visible because there is a bug where the urlbar perceived height is wrong, it should be 32px, it is 30px instead. This patch fixed that. I can't exclude there may be later time tweaks after the ux review or during the Nightly cycle.
Bug 1696628 Comment 19 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to aminomancer from comment #16) > @:mak but also it depends on the image, if the icon width is not set explicitly, some of the images get squashed a little bit depending on the window scaling. and setting 1.5px padding as a general rule doesn't seem wise, since it's rendered differently depending on the window scaling too. this doesn't look right for me at 150% on windows 10 for example. I'm at 125%, it was not exactly right for me too, but that's what the spec says. This is more visible because there is a bug where the urlbar perceived height is wrong, it should be 32px, it is 30px instead. This patch fixed that. I can't exclude there may be later time tweaks after the ux review or during the Nightly cycle.
(In reply to aminomancer from comment #16) > @:mak but also it depends on the image, if the icon width is not set explicitly, some of the images get squashed a little bit depending on the window scaling. and setting 1.5px padding as a general rule doesn't seem wise, since it's rendered differently depending on the window scaling too. this doesn't look right for me at 150% on windows 10 for example. I'm at 125%, it was not exactly right for me too, but that's what the spec says. This is more visible because there is a bug where the urlbar perceived height is wrong, it should be 32px, it is 30px instead. This patch fixes that. I can't exclude there may be later time tweaks after the ux review or during the Nightly cycle.