We currently have these [6 strings that refer to taskbar](https://searchfox.org/mozilla-central/search?q=pin.*taskbar&path=.ftl®exp=true): ``` default browser prompt default-browser-prompt-message-pin = Keep { -brand-short-name } at your fingertips — make it your default browser and pin it to your taskbar. about:welcome onboarding-multistage-pin-default-help-text = This will pin { -brand-short-name } to taskbar and open settings mr1-onboarding-set-default-pin-primary-button-label.title = Sets { -brand-short-name } as default browser and pins to taskbar upgrade dialog upgrade-dialog-new-primary-primary-button.title = Sets { -brand-short-name } as default browser and pins to taskbar upgrade-dialog-new-primary-pin-button = Pin { -brand-short-name } to my taskbar upgrade-dialog-new-primary-pin-alt-button = Pin to taskbar ``` We could skip one of the about:welcome as that’s pre-proton and one of the upgrade dialog as it’s the string before 3-screens. So for mac, we'll want at least 4 new strings and new pin/default images on upgrade onboarding, which we might also use for about:welcome? Ana, which strings should we be making mac versions? And will we be changing about:welcome to have the "pin" then "default" in 90, which would then have new strings to land including "Pin to Taskbar" and "Pin Firefox to your taskbar" as well as potentially others based on the followup pin experiment and user studies? Meridel, what should the mac versions say? The macOS UI shows a menu option of "Keep in Dock" so maybe just that, so Firefox buttons show "Keep in dock" and text with "…make it your default and keep in your dock" ? Also, if we do continue with the "primary browser" language which about:welcome explains with "and open settings" help text, I suppose we should have something similar for macOS's permission prompt (see attached)? flod, these wording differences seem to suggest using fluent selectors as it's the same behavior but OS refers to the surfaces differently. Given that we have existing windows fluent strings, can/should the existing ones be migrated to a new string with selector? ``` upgrade-dialog-new-primary-keep-pin-button = { PLATFORM() -> [macos] Keep in dock *[other] Pin to taskbar } upgrade-dialog-new-primary-keep-pin-button = { PLATFORM() -> [macos] {nothing exists…? should this line be omitted? migration won't work?} *[other] {COPY_PATTERN(from_path, "upgrade-dialog-new-primary-pin-alt-button")} } ```
Bug 1699842 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
We currently have these [6 strings that refer to taskbar](https://searchfox.org/mozilla-central/search?q=pin.*taskbar&path=.ftl®exp=true): ``` default browser prompt default-browser-prompt-message-pin = Keep { -brand-short-name } at your fingertips — make it your default browser and pin it to your taskbar. about:welcome [old?] onboarding-multistage-pin-default-help-text = This will pin { -brand-short-name } to taskbar and open settings mr1-onboarding-set-default-pin-primary-button-label.title = Sets { -brand-short-name } as default browser and pins to taskbar upgrade dialog upgrade-dialog-new-primary-primary-button.title = Sets { -brand-short-name } as default browser and pins to taskbar [old?] upgrade-dialog-new-primary-pin-button = Pin { -brand-short-name } to my taskbar upgrade-dialog-new-primary-pin-alt-button = Pin to taskbar ``` We could skip one of the about:welcome as that’s pre-proton and one of the upgrade dialog as it’s the string before 3-screens. So for mac, we'll want at least 4 new strings and new pin/default images on upgrade onboarding, which we might also use for about:welcome? Ana, which strings should we be making mac versions? And will we be changing about:welcome to have the "pin" then "default" in 90, which would then have new strings to land including "Pin to Taskbar" and "Pin Firefox to your taskbar" as well as potentially others based on the followup pin experiment and user studies? Meridel, what should the mac versions say? The macOS UI shows a menu option of "Keep in Dock" so maybe just that, so Firefox buttons show "Keep in dock" and text with "…make it your default and keep in your dock" ? Also, if we do continue with the "primary browser" language which about:welcome explains with "and open settings" help text, I suppose we should have something similar for macOS's permission prompt (see attached)? flod, these wording differences seem to suggest using fluent selectors as it's the same behavior but OS refers to the surfaces differently. Given that we have existing windows fluent strings, can/should the existing ones be migrated to a new string with selector? ``` upgrade-dialog-new-primary-keep-pin-button = { PLATFORM() -> [macos] Keep in dock *[other] Pin to taskbar } upgrade-dialog-new-primary-keep-pin-button = { PLATFORM() -> [macos] {nothing exists…? should this line be omitted? migration won't work?} *[other] {COPY_PATTERN(from_path, "upgrade-dialog-new-primary-pin-alt-button")} } ```