Bug 1699842 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Ed Lee :Mardak from comment #6)
> > flod, these wording differences seem to suggest using fluent selectors as it's the same behavior but OS refers to the surfaces differently. Given that we have existing windows fluent strings, can/should the existing ones be migrated to a new string with selector?
> 
> Migrating partial strings is not an option. 
> 
> If you do, that partial translation would be treated as translated, with an empty macOS variant.

Given this seems to be touching pretty much all the dialog, I'd suggest to use different strings instead of a PLATFORM() selector. At least, the strings for Windows would remain translated.
(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Ed Lee :Mardak from comment #6)
> > flod, these wording differences seem to suggest using fluent selectors as it's the same behavior but OS refers to the surfaces differently. Given that we have existing windows fluent strings, can/should the existing ones be migrated to a new string with selector?
> 
> Migrating partial strings is not an option. 
> 
> If you do, that partial translation would be treated as translated, with an empty macOS variant.

Given this seems to be touching pretty much all the dialog, I'd suggest to use different strings instead of a PLATFORM() selector. At least, the strings for Windows would remain translated.

EDIT: never mind, didn't realize that most of the Windows strings were changing as well.

Back to Bug 1699842 Comment 16