Bug 1701190 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
```
windowID = top->GetCurrentWindowContext()->OuterWindowId();
     00007FFCC58E0C02 48 8B 83 58 03 00 00 mov         rax,qword ptr [rbx+358h]  
->   RAX = 0000000000000000
>>>> 00007FFCC58E0C09 4C 8B B0 70 01 00 00 mov         r14,qword ptr [rax+170h]  
```
means probably that `top->GetCurrentWindowContext()` returns a `nullptr`. It [seems from here](https://searchfox.org/mozilla-central/rev/6309f663e7396e957138704f7ae7254c92f52f43/docshell/base/BrowsingContext.cpp#2920-2942) that it must be expected to be `nullptr` sometimes, instead.

Bug 1646505 changed that specific line, leading probably to the higher frequency. There might be chances that this is not the only potentially broken pointer access in `ReportPerfomranceInfo`, though.
Revision 1 by
on 
```
windowID = top->GetCurrentWindowContext()->OuterWindowId();
     00007FFCC58E0C02 48 8B 83 58 03 00 00 mov         rax,qword ptr [rbx+358h]  
->   RAX = 0000000000000000
>>>> 00007FFCC58E0C09 4C 8B B0 70 01 00 00 mov         r14,qword ptr [rax+170h]  
```
means probably that `top->GetCurrentWindowContext()` returns a `nullptr`. It [seems from here](https://searchfox.org/mozilla-central/rev/6309f663e7396e957138704f7ae7254c92f52f43/docshell/base/BrowsingContext.cpp#2920-2942) that it must be expected to be `nullptr` sometimes, instead.

Bug 1646505 changed that specific line, leading probably to the higher frequency. There might be chances that this is not the only potentially broken pointer access in `ReportPerformanceInfo`, though.
Revision 2 by
on 
```
windowID = top->GetCurrentWindowContext()->OuterWindowId();
     00007FFCC58E0C02 48 8B 83 58 03 00 00 mov         rax,qword ptr [rbx+358h]  
->   RAX = 0000000000000000
>>>> 00007FFCC58E0C09 4C 8B B0 70 01 00 00 mov         r14,qword ptr [rax+170h]  
```
means probably that `top->GetCurrentWindowContext()` returns a `nullptr`. It [seems from here](https://searchfox.org/mozilla-central/rev/6309f663e7396e957138704f7ae7254c92f52f43/docshell/base/BrowsingContext.cpp#2920-2942) that it must be expected to be `nullptr` sometimes, instead.

Bug 1646505 changed that specific line, contributing probably to the higher frequency. There might be chances that this is not the only potentially broken pointer access in `ReportPerformanceInfo`, though.

Back to Bug 1701190 Comment 1