Bug 1702310 Comment 11 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I found time to look a this. An update: the problem in the above push seems to be that --gecko-interval defaults to 0, which is not None, and so the gecko profiler is turned on for jobs that don't pass any of that flags. Oops. I was only testing jobs where I passed a bare `--gecko-profile` and jobs where I passed both `--gecko-profile-threads` and `--gecko-profile-features`, not jobs where I didn't pass anything. Oops again. (Also, I only tested on Linux, and the incorrectly profiled jobs don't crash there to make it obvious. On Windows, everything falls apart for some reason.)

I've fixed that, but I'm noticing a second issue: on Windows at least, passing `--gecko-profile-threads=MainThread,Compositor,DOM Worker,Renderer` is resulting in the threads `["MainThread", "Compositor", "DOM"]`. It must be splitting a command line on the space character. So I still need to fix that before trying to re-land. It is possible that it is a pre-existing bug, but at the very least this patch would expose it much more easily.
Revision 1 by
on 
I found time to look at this.

An update: the problem in the above push seems to be that `--gecko-interval` defaults to `0`, which is not `None`, and so the gecko profiler is turned on for jobs that don't pass any of that flags. Oops. I was only testing jobs where I passed a bare `--gecko-profile` and jobs where I passed both `--gecko-profile-threads` and `--gecko-profile-features`, not jobs where I didn't pass anything. Oops again. (Also, I only tested on Linux, and the incorrectly profiled jobs don't crash there to make it obvious. On Windows, everything falls apart for some reason.)

I've fixed that, but I'm noticing a second issue: on Windows at least, passing `--gecko-profile-threads=MainThread,Compositor,DOM Worker,Renderer` is resulting in the threads `["MainThread", "Compositor", "DOM"]`. It must be splitting a command line on the space character. So I still need to fix that before trying to re-land. It is possible that it is a pre-existing bug, but at the very least this patch would expose it much more easily.

Back to Bug 1702310 Comment 11