From item 3 in comment 39 above: >If first line starts with "From " it is ignored. To correctly describe the patch this should say "If first line start with "From " or if the folder is Drafts and the first line starts with "FCC" it is ignored. However, looking at mbox file for Drafts I never actually see the first line start with "FCC". They always actually start with "From " like any other folder's mbox file. Instead I see, usually after the last X-MOZILLA-STATUS line a header line like this: ``` FCC: imap://gds@mail.tana.it/INBOX/Sent ``` However, I see this appear at other locations down in the file for some messages, but again, never as the first line. So this will just be seen as another valid header line that may mark the starting offset of data read from the file for the message. (What the FCC: header is used for is unclear to me.) Anyhow, I'll keep the code the same and and check for leading "FCC" when folder is Drafts even thought it seems to never occur (but maybe in some legacy mbox files?). I'm looking again at the diff before submitting a formal patch. I'll at least need to take out the printf's.
Bug 1702692 Comment 45 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
From item 3 in comment 39 above: >If first line starts with "From " it is ignored. To correctly describe the patch this should say "If first line start with "From " or if the folder is Drafts and the first line starts with "FCC" it is ignored. However, looking at mbox file for Drafts I never actually see the first line start with "FCC". They always actually start with "From " like any other folder's mbox file. Instead I see, usually after the last X-MOZILLA-STATUS line a header line like this: ``` FCC: imap://gds@mail.tana.it/INBOX/Sent ``` However, I see this appear at other locations down in the file for some messages, but again, never as the first line. So this will just be seen as another valid header line that may mark the starting offset of data read from the file for the message. (What the FCC: header is used for is unclear to me.) Anyhow, I'll keep the code the same and and check for leading "FCC" when folder is Drafts even though it seems to never occur (but maybe in some legacy mbox files?). I'm looking again at the diff before submitting a formal patch. I'll at least need to take out the printf's.