Bug 1704500 Comment 15 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
tl;dr

* ```SetHighAccuracy``` should set a member flag but not assume ```mLocation``` already exists and that it can call stuff on it
* ```QueryInterface``` on ```LocationEvent``` should be bugfixed just because
* The ```LocationEvent``` passed into ```RegisterForReport``` needs to be a global that either owns mProvider too (yuck) or we need to carefully and thread-safetly set/unset it as a member (also yuck).
Revision 1 by
on 
tl;dr

* ```SetHighAccuracy``` should set a member flag but not assume ```mLocation``` already exists and that it can call stuff on it
* ```QueryInterface``` on ```LocationEvent``` should be bugfixed just because
* The ```LocationEvent``` passed into ```RegisterForReport``` needs to be a global that either owns ```mProvider``` too (yuck) or we need to carefully and thread-safetly set/unset it as a member (also yuck).
Revision 2 by
on 
tl;dr

* ```SetHighAccuracy``` should set a member flag but not assume ```mLocation``` already exists and that it can call stuff on it
* ```QueryInterface``` on ```LocationEvent``` should be bugfixed just because
* The ```LocationEvent``` passed into ```RegisterForReport``` needs to be a global that either owns ```mProvider``` too (yuck, at least there should be only one) or we need to carefully and thread-safetly set/unset it as a member (also yuck).
Revision 3 by
on 
tl;dr

* ```SetHighAccuracy``` should set a member flag but not assume ```mLocation``` already exists and that it can call stuff on it
* ```QueryInterface``` on ```LocationEvent``` should be bugfixed just because
* The ```LocationEvent``` passed into ```RegisterForReport``` needs to be a global that either owns ```mProvider``` too (yuck, at least there should be only one) or we need to carefully and thread-safely set/unset it as a member (also yuck).
Revision 4 by
on 
tl;dr

* ```SetHighAccuracy``` should set a member flag but not assume ```mLocation``` already exists and that it can call stuff on it
* ```QueryInterface``` on ```LocationEvent``` should be bugfixed just because
* ~~The ```LocationEvent``` passed into ```RegisterForReport``` needs to be a global that either owns ```mProvider``` too (yuck, at least there should be only one) or we need to carefully and thread-safely set/unset it as a member (also yuck).~~ Seems unlikely this would fix anything based on current analysis.

Back to Bug 1704500 Comment 15