Bug 1706678 Comment 17 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Conic gradients much larger than 2048 pixels would render quite wrong during the 89 cycle but conic gradients are fairly rare so perhaps it's not worth the risk. The bustage comes from a reference image that was regenerated in Bug 1707181. It's not clear to me why but the png of the reference isn't loaded anymore (eve though it worked fine on central). This patch doesn't apply cleanly without the one in bug 1707181.

The simplest thing is to just accept that very large conic gradients will render very wrong (and very large radial gradients slightly wrong) and avoid the risk of a late uplift.

If we do want to take the risk of the late uplift, the safest thing would be to disable the reftest that fails to land the reference image (removing the line `platform(linux,mac) == blend-clipped.yaml blend-clipped.png` in `gfx/wr/wrench/reftests/filters/reftest.list`.
Conic gradients much larger than 2048 pixels would render quite wrong during the 89 cycle but conic gradients are fairly rare so perhaps it's not worth the risk. The bustage comes from a reference image that was regenerated in Bug 1707181. It's not clear to me why but the png of the reference isn't loaded anymore (eve though it worked fine on central). This patch doesn't apply cleanly without the one in bug 1707181.

The simplest thing is to just accept that very large conic gradients will render very wrong (and very large radial gradients slightly wrong) and avoid the risk of a late uplift.

If we do want to take the risk of the late uplift, the safest/simplest thing would be to disable the reftest that fails to land the reference image (removing the line `platform(linux,mac) == blend-clipped.yaml blend-clipped.png` in `gfx/wr/wrench/reftests/filters/reftest.list`.
Conic gradients much larger than 2048 pixels would render quite wrong during the 89 cycle but conic gradients are fairly rare so perhaps it's not worth the risk. The bustage comes from a reference image that was regenerated in Bug 1707181. It's not clear to me why but the png of the reference isn't loaded anymore (eve though it worked fine on central). This patch doesn't apply cleanly without the one in bug 1707181.

The simplest thing is to just accept that very large conic gradients will render very wrong (and very large radial gradients slightly wrong) and avoid the risk of a late uplift.

If we do want to take the risk of the late uplift, the safest/simplest thing would be to disable the reftest that fails to load the reference image (removing the line `platform(linux,mac) == blend-clipped.yaml blend-clipped.png` in `gfx/wr/wrench/reftests/filters/reftest.list`.

Back to Bug 1706678 Comment 17