This bug confuses me. We switch of the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there. It does not care about icons. If I have menupopups without such things, the icon is still not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if that class is present?
Bug 1706895 Comment 9 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
This bug confuses me. We switch of the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without such things, the icon is still not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if that class is present?
This bug confuses me. We switch of the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons and the icons are consequently not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if that class is present?
This bug confuses me. We switch of the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons and the icons are consequently not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if that new class is present?
This bug confuses me. We switch of the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons and the icons are consequently not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class like `menupopup-iconic`, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if the `menupopup-iconic` class is present?
This bug confuses me. We switch off the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons and the icons are consequently not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class like `menupopup-iconic`, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if the `menupopup-iconic` class is present?
This bug confuses me. We switch off the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons (in the menus WebExtension API) and the icons are consequently not shown. And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class like `menupopup-iconic`, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if the `menupopup-iconic` class is present?
This bug confuses me. We switch off the icons in menupopups, if there is no needsgutter attribute. The needsgutter attribute cannot be enforced, it is auto-controlled by this: https://searchfox.org/comm-central/rev/b4465cecab137702144ec8a2b3f8d6779971f60f/mozilla/toolkit/content/widgets/menupopup.js#30 So only if there is a radio or checkbox type menuitem in there, the needsgutter attribute is added. It does not care about icons. If I have menupopups without checkboxes or icons (in the menus WebExtension API) and the icons are consequently not shown (but we need them). And adding a needsgutter attribute does not help, as the linked code removes it again. Can we have a new class like `menupopup-iconic`, which I can apply to a menupopup, which overrides this behavior? So that needsgutter will not be used as a check to hide icons if the `menupopup-iconic` class is present? Or can we limit this needsgutter behavior to some areas of TB but not everywhere?