Yeah, the stuff we're negotiating in SDP is definitely never ending up in SdpVideoFormat::parameters, and therefore not making it down into the code in [WebrtcMediaDataEncoder::CreateEncoder](https://searchfox.org/mozilla-central/rev/71befbc9bc348d33f0c7307dc48e3cb36ba78650/dom/media/webrtc/libwebrtcglue/WebrtcMediaDataEncoderCodec.cpp#236). We just end up using the default in [ParseSdpProfileLevelId](https://searchfox.org/mozilla-central/rev/f465d324513f09dbe33ed79fabe6a9ef98aa51ca/third_party/libwebrtc/media/base/h264_profile_level_id.cc#204-205). Now, this just _happens_ to be the same thing as what we negotiate by default, but I think we end up doing the wrong thing if SDP negotiation settles on something else.
Bug 1706917 Comment 47 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Yeah, the stuff we're negotiating in SDP is definitely never ending up in SdpVideoFormat::parameters, and therefore not making it down into the code in [WebrtcMediaDataEncoder::CreateEncoder](https://searchfox.org/mozilla-central/rev/71befbc9bc348d33f0c7307dc48e3cb36ba78650/dom/media/webrtc/libwebrtcglue/WebrtcMediaDataEncoderCodec.cpp#236). We just end up using the default in [ParseSdpProfileLevelId](https://searchfox.org/mozilla-central/rev/f465d324513f09dbe33ed79fabe6a9ef98aa51ca/third_party/libwebrtc/media/base/h264_profile_level_id.cc#204-205). Now, this just _happens_ to be the same thing that we negotiate by default, but I think we end up doing the wrong thing if SDP negotiation settles on something else.
Yeah, the stuff we're negotiating in SDP is definitely never ending up in SdpVideoFormat::parameters, and therefore not making it down into the code in [WebrtcMediaDataEncoder::CreateEncoder](https://searchfox.org/mozilla-central/rev/71befbc9bc348d33f0c7307dc48e3cb36ba78650/dom/media/webrtc/libwebrtcglue/WebrtcMediaDataEncoderCodec.cpp#236). We just end up using the default in [ParseSdpProfileLevelId](https://searchfox.org/mozilla-central/rev/f465d324513f09dbe33ed79fabe6a9ef98aa51ca/third_party/libwebrtc/media/base/h264_profile_level_id.cc#204-205). Now, this just _happens_ to be the same thing that we negotiate by default, but we end up doing the wrong thing if SDP negotiation settles on something else.