Bug 1709019 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

We currently report the last entered shutdown phase only if [`!sShutdownNotified`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/toolkit/components/terminator/nsTerminator.cpp#200), otherwise we report a generic [`Shutdown hanging after all known phases and workers finished.`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/toolkit/components/terminator/nsTerminator.cpp#246).

But after [`mozilla::XPCOMShutdownNotified();`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/xpcom/build/XPCOMInit.cpp#614) there is still quite some way to go and we even report [`mozilla::ShutdownPhase::XPCOMShutdownThreads`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/xpcom/build/XPCOMInit.cpp#622-623) afterwards, with no effect on the reporting.

Given some recent spikes in late shutdown hangs (bug 1684441, bug 1358898) we want to be able to monitor also late shutdown and maybe even add some more phases to late shutdown.
We currently report the last entered shutdown phase only if [`!sShutdownNotified`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/toolkit/components/terminator/nsTerminator.cpp#200), otherwise we report a generic [`Shutdown hanging after all known phases and workers finished.`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/toolkit/components/terminator/nsTerminator.cpp#246).

But after [`mozilla::XPCOMShutdownNotified();`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/xpcom/build/XPCOMInit.cpp#614) there is still quite some way to go and we even advance to [`mozilla::ShutdownPhase::XPCOMShutdownThreads`](https://searchfox.org/mozilla-central/rev/9f76a47f4aa935b49754c5608a1c8e72ee358c46/xpcom/build/XPCOMInit.cpp#622-623) afterwards, with no effect on the reporting.

Given some recent spikes in late shutdown hangs (bug 1684441, bug 1358898) we want to be able to monitor also late shutdown and maybe even add some more phases to late shutdown.

Back to Bug 1709019 Comment 0