Because of bug 1711700, we cannot enable the branch with just an empty object and will need to specify `screens` in the JSON. We will workaround by providing a `screens` array which will dynamically switch a "default" button to "primary" button for users who can and need to pin: https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#586-602 However, the string that gets used has slightly different casing than what is currently shown in 88: ``` mr1-onboarding-set-default-pin-primary-button-label = Make { -brand-short-name } my primary browser .title = Sets { -brand-short-name } as default browser and pins to taskbar onboarding-multistage-pin-default-primary-button-label = Make { -brand-short-name } My Primary Browser ``` There are also other changes that happen when Firefox can be pinned for the holdback group, e.g., different text, default gif when waiting for default: https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#445-489 So we can switch the targeting to be windows 10 1903+ and assume firefox will need to be pinned. Or keep the current targeting of first startup en users and always show "default" even if firefox needs to be pinned?
Bug 1709718 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Because of bug 1711700, we cannot enable the branch with just an empty object (attempting to use the normal non-experiment screens) and will need to specify `screens` in the JSON. We can workaround by providing a `screens` array which will dynamically switch a "default" button to "primary" button for users who can and need to pin: https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#586-602 However, the string that gets used has slightly different casing than what is currently shown in 88: ``` mr1-onboarding-set-default-pin-primary-button-label = Make { -brand-short-name } my primary browser .title = Sets { -brand-short-name } as default browser and pins to taskbar onboarding-multistage-pin-default-primary-button-label = Make { -brand-short-name } My Primary Browser ``` There are also other changes that happen when Firefox can be pinned for the holdback group, e.g., different text, default gif when waiting for default: https://searchfox.org/mozilla-central/rev/443f87caa5fadba920b0382e12874693d6c6133a/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm#445-489 So we can switch the targeting to be windows 10 1903+ and assume firefox will need to be pinned. Or keep the current targeting of first startup en users and always show "default" even if firefox needs to be pinned?