Bug 1713276 Comment 92 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #91)
> Alastor, may you land it with media.ffmpeg.customized-buffer-allocation set to false to pass tests and enable it in another patch when all tests are fixed? That will save your time with rebases to latest trunk. It also helps to ensure it doesn't break anything when the pref if off.

It's ok, that new failure is in my expectation and I know why it failed. (See [this](https://phabricator.services.mozilla.com/D134352#4392240)) I just forgot to handle that as we disable shmem-decoding on Windows. After I modify patch4 again and do full testing, and ensure everything is ok, I will reland them again.
(In reply to Martin Stránský [:stransky] (ni? me) from comment #91)
> Alastor, may you land it with media.ffmpeg.customized-buffer-allocation set to false to pass tests and enable it in another patch when all tests are fixed? That will save your time with rebases to latest trunk. It also helps to ensure it doesn't break anything when the pref if off.

It's ok, that new failure is in my expectation and I know why it failed. (See [this](https://phabricator.services.mozilla.com/D134352#4392240), and that should be fixed in bug 1748540) I just forgot to handle that as we disable shmem-decoding on Windows. After I modify patch4 again and do full testing, and ensure everything is ok, I will reland them again.
(In reply to Martin Stránský [:stransky] (ni? me) from comment #91)
> Alastor, may you land it with media.ffmpeg.customized-buffer-allocation set to false to pass tests and enable it in another patch when all tests are fixed? That will save your time with rebases to latest trunk. It also helps to ensure it doesn't break anything when the pref if off.

It's ok, that new failure is in my expectation and I know why it failed. (See [this](https://phabricator.services.mozilla.com/D134352#4392240), and that should be fixed in bug 1748540) I just forgot to handle that as we disable shmem-decoding for 10bit+ videos on Windows in the last update. After I modify patch4 again and do full testing, and ensure everything is ok, I will reland them again.

Back to Bug 1713276 Comment 92