I took a look too before seeing emilio's comment. tl;dr: nothing here seems like it should block shipping Fission MVP. (In reply to Chris Peterson [:cpeterson] from comment #2) > Sam, here is a browser_print_in_container.js failure with Fission. This failure might be a duplicate of bug 1683279, where you skipped browser_print_in_container.js for Linux asan. Do you think this Fission failure should block shipping Fission MVP? Minor correction: it looks like we skipped browser_print_in_container.js for **linux64 debug** over there (not for ASAN). Whereas, the failures here are on linux opt ASAN (with fission). In any case, it does look like we are seeing failures in that test with linux opt ASAN *without* fission as well -- e.g. this log from the most recent intermittent-failure-bot comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1683279#c37 : https://treeherder.mozilla.org/logviewer?job_id=341329196&repo=mozilla-beta&lineNumber=6984 So I think we can consider this test failure to be wholly unrelated to fission. > I don't see any browser_modal_print.js failures in recent Fission browser-chrome try runs (before these Fission skip-if annotations were added). We can probably just remove the browser_modal_print.js annotation and see what happens. We have had some false positive bug reports for Fission browser-chrome failures. I haven't been able to find any failures in this test at all -- I clicked around in the try run from comment 0 and I couldn't find any mention of this test. So, if there were problems with this test at some point (which I'm not clear on), it's good to hear we're not seeing failures now at least. :) So I agree we should be able to remove the fission-specific annotations here. (Seems like we can drop the annotation for browser_modal_print.js entirely, and maybe just drop the 'fission' condition for browser_print_in_container.js.
Bug 1713912 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I took a look too before seeing emilio's comment. tl;dr: nothing here seems like it should block shipping Fission MVP. (In reply to Chris Peterson [:cpeterson] from comment #2) > Sam, here is a browser_print_in_container.js failure with Fission. This failure might be a duplicate of bug 1683279, where you skipped browser_print_in_container.js for Linux asan. Do you think this Fission failure should block shipping Fission MVP? Minor correction: it looks like we skipped browser_print_in_container.js for **linux64 debug** over there (not for ASAN). Whereas, the failures here are on linux opt ASAN (with fission). In any case, it does look like we are seeing failures in that test with linux opt ASAN *without* fission as well -- e.g. this log from the most recent intermittent-failure-bot comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1683279#c37 : https://treeherder.mozilla.org/logviewer?job_id=341329196&repo=mozilla-beta&lineNumber=6984 So I think we can consider this test failure to be wholly unrelated to fission. > I don't see any browser_modal_print.js failures in recent Fission browser-chrome try runs (before these Fission skip-if annotations were added). We can probably just remove the browser_modal_print.js annotation and see what happens. We have had some false positive bug reports for Fission browser-chrome failures. I haven't been able to find any failures in this test at all -- I clicked around in the try run from comment 0 and I couldn't find any mention of this test failing. (The three linux-asan bc8 test-runs from that Try run all actually show this test **running & passing**.) So, if there were problems with this test at some point (which I'm not clear on), it's good to hear we're not seeing failures now at least. :) So I agree we should be able to remove the fission-specific annotations here. (Seems like we can drop the annotation for browser_modal_print.js entirely, and maybe just drop the 'fission' condition for browser_print_in_container.js.
I took a look too before seeing emilio's comment. tl;dr: nothing here seems like it should block shipping Fission MVP. (In reply to Chris Peterson [:cpeterson] from comment #2) > Sam, here is a browser_print_in_container.js failure with Fission. This failure might be a duplicate of bug 1683279, where you skipped browser_print_in_container.js for Linux asan. Do you think this Fission failure should block shipping Fission MVP? Minor correction: it looks like we skipped browser_print_in_container.js for **linux64 debug** over there (not for ASAN). Whereas, the failures here are on linux opt ASAN (with fission). In any case, it does look like we are seeing failures in that test with linux opt ASAN *without* fission as well -- e.g. this log from the most recent intermittent-failure-bot comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1683279#c37 : https://treeherder.mozilla.org/logviewer?job_id=341329196&repo=mozilla-beta&lineNumber=6984 So I think we can consider this test failure to be wholly unrelated to fission. > I don't see any browser_modal_print.js failures in recent Fission browser-chrome try runs (before these Fission skip-if annotations were added). We can probably just remove the browser_modal_print.js annotation and see what happens. We have had some false positive bug reports for Fission browser-chrome failures. I haven't been able to find any failures in this test at all -- I clicked around in the try run from comment 0 and I couldn't find any mention of this test failing. (The three linux-asan bc8 test-runs from that Try run all actually show this test **running & passing**, in their raw logs.) So, if there were problems with this test at some point (which I'm not clear on), it's good to hear we're not seeing failures now at least. :) So I agree we should be able to remove the fission-specific annotations here. (Seems like we can drop the annotation for browser_modal_print.js entirely, and maybe just drop the 'fission' condition for browser_print_in_container.js.