What needs to be discusses is how invasive the modification should be, to make it look good. The add-ons mentioned are doing quite a lot. I was aiming for a CSS only solution, but that is not really possible, as the invert of white is black and that it to dark to read. I now look at the background of the email itself and its first child elements, and everything that is "close to white" will be converted to `#2a2a2e` by JavaScript. I also do not flip JPGs but I have already seen emails with large PNGs which looks strange. So here i would like to suggest to manually check the size of images and decide based on that if an image should be flipped or not. I do think, small logos must be flipped. For example a png logo with transparent background with black strokes on white background will become invisible. If transparent background information can be extracted via JS, I could use that as well as flip selector. Something I was also thinking about is to extend my background transformation to the entire email, and not just the first childs. It definitely needs more feedback.
Bug 1715361 Comment 21 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
What needs to be discussed is how invasive the modification should be, to make it look good. The add-ons mentioned are doing quite a lot. I was aiming for a CSS only solution, but that is not really possible, as the invert of white is black and that it to dark to read. I now look at the background of the email itself and its first child elements, and everything that is "close to white" will be converted to `#2a2a2e` by JavaScript. I also do not flip JPGs but I have already seen emails with large PNGs which looks strange. So here i would like to suggest to manually check the size of images and decide based on that if an image should be flipped or not. I do think, small logos must be flipped. For example a png logo with transparent background with black strokes on white background will become invisible. If transparent background information can be extracted via JS, I could use that as well as flip selector. Something I was also thinking about is to extend my background transformation to the entire email, and not just the first childs. It definitely needs more feedback.
What needs to be discussed is how invasive the modification should be, to make it look good. The add-ons mentioned are doing quite a lot. I was aiming for a CSS only solution, but that is not really possible, as the invert of white is black and that it to dark to read. I now look at the background of the email itself and its first child elements, and everything that is "close to white" will be converted to `#2a2a2e` by JavaScript. I also do not flip JPGs but I have already seen emails with large PNGs which looks strange. So here I would like to suggest to manually check the size of images and decide based on that if an image should be flipped or not. I do think, small logos must be flipped. For example a png logo with transparent background with black strokes on white background will become invisible. If transparent background information can be extracted via JS, I could use that as well as flip selector. Something I was also thinking about is to extend my background transformation to the entire email, and not just the first childs. It definitely needs more feedback.