Bugzilla

thank you aki! that capacity flag had me confused for a while.

i noticed that after the rollout:
- the value of the `workerConfig.genericWorker.config.deploymentId` field was set to `f37dd7ee1cae`. [f37dd7ee1cae](https://github.com/mozilla-releng/OpenCloudConfig/commit/f37dd7ee1cae) refers to an occ commit from october 2019.
- the `workerConfig.genericWorker.config.livelogPUTPort` field was reinstated

it looks like these fields are set in ci-configuration. i have manually corrected them and am preparing a patch now. there was a growing pending task count because modern generic worker also panics and crashes on detection of the `livelogPUTPort` field. the pending count should resolve itself now that i have manually corrected configs but will require the ci-config patch that i am preparing shortly, going forward.

the deploymentId field is used by generic worker to determine if it should commit seppuku. between tasks, a worker checks if its own deployment id matches the deployment id of worker manager configuration, if it determines that it does not, it shuts itself down, effectively terminating the spot instance. this feature is exceptionally useful when rolling out upgrades as it provides a mechanism for workers to finish their immediate task before gracefully disappearing from our universe.

it would be useful if ci-admin were able to set the value of deploymentId to the commit hash of the last change for the workerType config in ci-config, but i'll just update the value for now which has the downside that it affects all generic-worker/windows workers instead of just the workers targeted by this patch.

thank you aki! that capacity flag had me confused for a while.

i noticed that after the rollout:
- the value of the `workerConfig.genericWorker.config.deploymentId` field was set to `f37dd7ee1cae`. [f37dd7ee1cae](https://github.com/mozilla-releng/OpenCloudConfig/commit/f37dd7ee1cae) refers to an occ commit from october 2019.
- the `workerConfig.genericWorker.config.livelogPUTPort` field was reinstated

it looks like these fields are set in ci-configuration. i have manually corrected them and am preparing a patch now. there was a growing pending task count because modern generic worker also panics and crashes on detection of the `livelogPUTPort` field. the pending count should resolve itself now that i have manually corrected configs but will require the ci-config patch that i am preparing shortly, going forward.

the deploymentId field is used by generic worker to determine if it should commit seppuku. between tasks, a worker checks if its own deployment id matches the deployment id of worker manager configuration, if it determines that it does not, it shuts itself down, effectively terminating the spot instance. this feature is exceptionally useful when rolling out upgrades as it provides a mechanism for workers to finish their immediate task before gracefully disappearing from our universe.

it would be useful if ci-admin were able to set the value of deploymentId to the commit hash of the last change for the workerType config in ci-config, but i'll just update the value for now ~~which has the downside that it affects all generic-worker/windows workers instead of just the workers targeted by this patch~~. - edit: i figured out how to target deploymentId for specific worker types