Bugzilla

mFeeds was never initialized again after creating the listener. onLocationChange in the status browser handler clears it but not always fired too and then repoulate with the bad cache too resulting in duplicate or defunct items in some cases.

[Approval Request Comment]
Regression caused by (bug #): Bug 1272401
User impact if declined: defunct feeds icon in the url bar and errors in console.
Testing completed (on m-c, etc.):  2.533.11b1pre
Risk to taking this patch (and alternatives if risky): low risk. Worst case is either a missing feeds icon or bad (old) behaviour if I picked the wrong location.
String changes made by this patch: --

mFeeds was never initialized again after creating the listener. onLocationChange in the status browser handler clears it but not always fired too and then repoulate with the bad cache too resulting in duplicate or defunct items in some cases.

See removal in:
https://hg.mozilla.org/comm-central/rev/dd8fa7b8bd65#l1.254

[Approval Request Comment]
Regression caused by (bug #): Bug 1272401
User impact if declined: defunct feeds icon in the url bar and errors in console.
Testing completed (on m-c, etc.):  2.533.11b1pre
Risk to taking this patch (and alternatives if risky): low risk. Worst case is either a missing feeds icon or bad (old) behaviour if I picked the wrong location.
String changes made by this patch: --

mFeeds was never initialized again after creating the listener. onLocationChange in the status browser handler clears it but not always fired too and then repoulates with the bad cache too resulting in duplicate or defunct items in some cases.

See removal in:
https://hg.mozilla.org/comm-central/rev/dd8fa7b8bd65#l1.254

[Approval Request Comment]
Regression caused by (bug #): Bug 1272401
User impact if declined: defunct feeds icon in the url bar and errors in console.
Testing completed (on m-c, etc.):  2.533.11b1pre
Risk to taking this patch (and alternatives if risky): low risk. Worst case is either a missing feeds icon or bad (old) behaviour if I picked the wrong location.
String changes made by this patch: --