(In reply to Alessandro Castellani [:aleca] from comment #0) > 1. The message text is added by creating a new `div` element and appending it inside the notification: https://searchfox.org/comm-central/rev/014b72575f40cf1d2e0cc1d997d8e4bebbd118f9/mail/components/compose/content/MsgComposeCommands.js#5145-5151 > This is not necessary since notifications allow adding and updating text pretty easily without creating any extra markup. Also, using a `div` inside a `label` element is semantically wrong. Yeah, I had seen that too, but decided to ignore ;-) I wasn't entirely sure if perhaps there was some sort of layout reason for the clumsy implementation. > This is not a severe bug but it's rather a task to clean up the implementation Let's make it a `task` then! Nice cleanup on top of my bug 1717085, this is in much better shape now.
Bug 1717127 Comment 3 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani [:aleca] from comment #0) > 1. The message text is added by creating a new `div` element and appending it inside the notification: https://searchfox.org/comm-central/rev/014b72575f40cf1d2e0cc1d997d8e4bebbd118f9/mail/components/compose/content/MsgComposeCommands.js#5145-5151 > This is not necessary since notifications allow adding and updating text pretty easily without creating any extra markup. Also, using a `div` inside a `label` element is semantically wrong. Yeah, I had seen that too, but decided to ignore ;-) I wasn't entirely sure if perhaps there was some sort of layout reason for the clumsy implementation. Nice cleanup on top of my bug 1717085, this is in much better shape now. Thanks for fixing the test failure.