Bug 1717227 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Another usability issue in the inline display is the link to add the contact to your address book.

Currently, you have to click the contact icon that appears at the start. It is semantically a `<a>` link (https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mailnews/addrbook/modules/VCardUtils.jsm#336), but with no text label in the accessibility tree. Plus, the link icon has no focus styling (it is explicitly removed https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mail/themes/linux/mail/messageBody.css#150).

An "Add to the address book" `title` attribute on the `<a>` link would be an easy fix. But this is currently not available to a visual, keyboard user. Plus, I think it is more useful/logical to have the option to add the contact appear later in the reading order, after the contact summary because it seems unlikely that anyone would decide to add a contact before they knew the details. Currently, this would require a backtrack.

I think even for visual users, clicking the icon to add to the address book is not intuitive. Personally, I was more visually directed to click the email address (but this just opens a new composition window).

A simple "Add to the address book"/"Edit in the address book" text button or link at the end, or underneath, would be clearest.
Another usability issue in the inline display is the link to add the contact to your address book.

Currently, you have to click the contact icon that appears at the start. It is semantically a `<a>` link (https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mailnews/addrbook/modules/VCardUtils.jsm#336), but with no text label in the accessibility tree. Plus, the link icon has no focus styling (it is explicitly removed https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mail/themes/linux/mail/messageBody.css#150).

An "Add to the address book" `title` attribute on the `<a>` link would be an easy fix. But this is currently not available to a visual, keyboard user. Plus, I think it is more useful/logical to have the option to add the contact appear later in the reading order, after the contact summary because it seems unlikely that anyone would decide to add a contact before they knew the details. Currently, this would require a backtrack.

I think even for visual users, clicking the icon to add to the address book is not intuitive. Personally, I was more visually directed to click the email address (but this just opens a new composition window).

A simple "Add Contact"/"Edit Contact" text button or link at the end, or underneath, would be clearest.
Another usability issue in the inline display is the link to add the contact to your address book.

Currently, you have to click the contact icon that appears at the start. It is semantically a `<a>` link (https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mailnews/addrbook/modules/VCardUtils.jsm#336), but with no text label in the accessibility tree. Plus, the link icon has no focus styling (it is explicitly removed https://searchfox.org/comm-central/rev/ea1278fae63adcd7fbc22407ff77a9851d38299f/mail/themes/linux/mail/messageBody.css#150).

An "Add Contact" `title` attribute on the `<a>` link would be an easy fix. But this is currently not available to a visual, keyboard user. Plus, I think it is more useful/logical to have the option to add the contact appear later in the reading order, after the contact summary because it seems unlikely that anyone would decide to add a contact before they knew the details. Currently, this would require a backtrack.

I think even for visual users, clicking the icon to add to the address book is not intuitive. Personally, I was more visually directed to click the email address (but this just opens a new composition window).

A simple "Add Contact"/"Edit Contact" text button or link at the end, or underneath, would be clearest.

Back to Bug 1717227 Comment 1