Bug 1719215 Comment 19 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I need to revise my patch. For large enough values of `aRect.X()` in [`CreateSubImageForData()`](https://hg.mozilla.org/mozilla-central/file/356c521826254fbae435b212923b20801d171950/gfx/2d/DrawTargetCairo.cpp#l257), I still see this bug's crashes, even with my patch. One extra line of allocation size isn't enough.

I don't yet fully understand how that code works -- particularly the clipping (if that's what it is) performed by `aRect`. I need to figure it out.
Revision 1 by
on 
I may need to revise my patch. For large enough values of `aRect.X()` in [`CreateSubImageForData()`](https://hg.mozilla.org/mozilla-central/file/356c521826254fbae435b212923b20801d171950/gfx/2d/DrawTargetCairo.cpp#l257), I still see this bug's crashes, even with my patch. One extra line of allocation size isn't enough.

I don't yet fully understand how that code works -- particularly the clipping (if that's what it is) performed by `aRect`. I need to figure it out.
Revision 2 by
on 
I may need to revise my patch. For large enough values of `aRect.X()` in [`CreateSubImageForData()`](https://hg.mozilla.org/mozilla-central/file/356c521826254fbae435b212923b20801d171950/gfx/2d/DrawTargetCairo.cpp#l257), I still see this bug's crashes, even with my patch. One extra line of allocation size may not be enough.

I don't yet fully understand how that code works -- particularly the clipping (if that's what it is) performed by `aRect`. I need to figure it out.

Back to Bug 1719215 Comment 19