Bug 1721084 Comment 52 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

As far as I'm concerned, the method introduced in Bug 1705035 is only ever called if the user actively clears site data via `nsIClearDataService`: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/toolkit/components/cleardata/nsIClearDataService.idl#78

Here are the callers of this method:
1. SiteDataManager: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/browser/modules/SiteDataManager.jsm#523
2. GeckoViewStorageController: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/mobile/android/modules/geckoview/GeckoViewStorageController.jsm#228
3. ForgetAboutSite: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/toolkit/components/forgetaboutsite/ForgetAboutSite.jsm#34

It seems unlikely that this code runs given the STR.

I can reproduce with the STR. From testing with the JS debugger, it doesn't like we ever hit this method.
As far as I'm concerned, the method introduced in Bug 1705035 is only ever called if the user actively clears site data via `nsIClearDataService`: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/toolkit/components/cleardata/nsIClearDataService.idl#78

Here are the callers of this method:
1. SiteDataManager: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/browser/modules/SiteDataManager.jsm#523
2. GeckoViewStorageController: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/mobile/android/modules/geckoview/GeckoViewStorageController.jsm#228
3. ForgetAboutSite: https://searchfox.org/mozilla-central/rev/d3683dbb252506400c71256ef3994cdbdfb71ada/toolkit/components/forgetaboutsite/ForgetAboutSite.jsm#34

It seems unlikely that this code runs given the STR.

I can reproduce with the STR. From testing with the JS debugger, it doesn't look like we ever hit this method.

Back to Bug 1721084 Comment 52