Dan, Landry, Petr: You've reported build issues due to profiler changes in the past. If possible and you have the time, could you please test the attached patches on your favorite systems? (Respectively: Linux/ppc64le and s390x, OpenBSD, Solaris) This is first to avoid introducing new failures straight away. But the main goal is to eventually remove the `MOZ_GECKO_PROFILER` #defines that are currently needed on your systems, so hopefully we will have fewer of these annoying build issues in the future; also parts of the profiler could run there!
Bug 1721569 Comment 13 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Dan, Landry, Petr: You've reported build issues due to profiler changes in the past. If possible and you have the time, could you please test the attached patches on your favorite systems? (Respectively: Linux/ppc64le and s390x, OpenBSD, Solaris) This is first to avoid introducing new failures straight away. But the main goal is to eventually remove the `MOZ_GECKO_PROFILER` #defines that are currently needed on your systems, so hopefully we will have fewer of these annoying build issues in the future; also parts of the profiler could run there! [edit] I forgot: After building, please test by running `<obj>/dist/bin/TestBaseProfiler`, and `./mach gtest *Profiler.*`. Thanks!