Bugzilla

(In reply to Emilio Cobos Álvarez (:emilio) from comment #15)
> (In reply to Martin Stránský [:stransky] (ni? me) from comment #13)
> > While popup is moved by move-to-rect we need to hide/show the popup. I think when the popup is shown again the transparent state is deleted although we think it's still set.
> 
> Right, but given the default is "not transparent", shouldn't that cause clicks to go the the popup? I still haven't been able to repro :/

Hm, you're right. 

From the debugging I did it looks like we set "transparent" by default for all popups and then "not transparent" later. I think the not transparent is  propagated incorrectly somehow, maybe there's a race condition when se hide/show the popup.

> Anyhow I think the cleanup I posted above should be worth landing (even if we land it in a separate bug or tag the bug as `leave-open`).

Sure, will look at it today.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #15)
> (In reply to Martin Stránský [:stransky] (ni? me) from comment #13)
> > While popup is moved by move-to-rect we need to hide/show the popup. I think when the popup is shown again the transparent state is deleted although we think it's still set.
> 
> Right, but given the default is "not transparent", shouldn't that cause clicks to go the the popup? I still haven't been able to repro :/

Hm, you're right. 

From the debugging I did it looks like we set "transparent" by default for all popups and then "not transparent" later. I think the not transparent is  propagated incorrectly somehow, maybe there's a race condition when we hide/show the popup.

> Anyhow I think the cleanup I posted above should be worth landing (even if we land it in a separate bug or tag the bug as `leave-open`).

Sure, will look at it today.