Bug 1728610 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Hello, you should keep updating the same revision, not post multiple revisions.
Please check the documentation at https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-update-a-submitted-patch

In practice, you make modifications on top of the original patch, then `hg commit --amend` those changes to merge them into the original revision, finally you submit the updated revision with moz-phab. This allows the reviewer to check the history of changes and the evolution of the revision across reviews.
Note Phabricator doesn't have something like the squash feature of github, you must squash your revisions manually, by amending changes to an existing revision where necessary.
Once you end up in the current state (multiple revisions on top of each other while you should only have one) you can still fix the problem by using the rebase command. `hg rebase -s source -d dest --collapse" will collapse dest and all the child revisions into a single revision on top of source.
For example if you have:
rev2
rev1
central
you would `hg rebase -s rev1 -d central --collapse` and you'd obtain:
rev1+2
central

Once you have merged the revisions, just push them again using moz-phab. The quick reference should have enough information to do that, but feel free to ask if you find difficulties.

Last thing, when you ask for review, the reviewer automatically gets notified about it, you don't need to also set the Request information from field, that field is only necessary when you post a question in a bugzilla comment and need an answer to proceed.
Hello, you should keep updating the same revision, not post multiple revisions.
Please check the documentation at https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-update-a-submitted-patch

In practice, you make modifications on top of the original patch, then `hg commit --amend` those changes to merge them into the original revision, finally you submit the updated revision with moz-phab. This allows the reviewer to check the history of changes and the evolution of the revision across reviews.
Note Phabricator doesn't have something like the squash feature of github, you must squash your revisions manually, by amending changes to an existing revision where necessary.
Once you end up in the current state (multiple revisions on top of each other while you should only have one) you can still fix the problem by using the rebase command. `hg rebase -s source -d dest --collapse` will collapse dest and all the child revisions into a single revision on top of source.
For example if you have:
rev2
rev1
central
you would `hg rebase -s rev1 -d central --collapse` and you'd obtain:
rev1+2
central

Once you have merged the revisions, just push them again using moz-phab. The quick reference should have enough information to do that, but feel free to ask if you find difficulties.

Last thing, when you ask for review, the reviewer automatically gets notified about it, you don't need to also set the Request information from field, that field is only necessary when you post a question in a bugzilla comment and need an answer to proceed.

Back to Bug 1728610 Comment 14