Bugzilla

(In reply to Calixte Denizet (:calixte) from comment #17)
> Is it a bot error: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1632010#c1 ?

No; but it can be improved.

1) Updatebot will attempt to edit moz.build files when it add/removes files from the repository.  It is somewhat successful in doing that, depending on the complexity of the moz.build file.  If it cannot figure it out, it will report a warning and put the entire contents of the command into a comment.  The relevant line is `Could not remove toolkit/components/pdfjs/content/web/images/toolbarButton-openFile.svg from the appropriate moz.build file`
2) The entire output of the update script is included in that comment.

I can improve this by making the rsync commands quiet (so we don't see the files it copies) _or_ since it looks like pdf.js moz.build file isn't really going to change based on pdfjs updates, I can just tell it to skip the moz.build editing step.

(In reply to Calixte Denizet (:calixte) from comment #17)
> Is it a bot error: https://bugzilla-dev.allizom.org/show_bug.cgi?id=1632010#c1 ?

No; but it can be improved.

1) Updatebot will attempt to edit moz.build files when it add/removes files from the repository.  It is somewhat successful in doing that, depending on the complexity of the moz.build file.  If it cannot figure it out, it will report a warning and put the entire contents of the command into a comment.  The relevant line is `Could not remove toolkit/components/pdfjs/content/web/images/toolbarButton-openFile.svg from the appropriate moz.build file`
2) The entire output of the update script is included in that comment.

I can improve this by making the rsync commands quiet (so we don't see the files it copies) _or_ since it looks like pdf.js moz.build file isn't really going to change based on pdfjs updates, I can just tell it to skip the moz.build editing step. (I edited the patch to do the latter)