Bug 1733532 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The variables that result in generating the stack cookie checks are `mbi` and `sectionFileName`. The proposed patch moves them to a helper function, so that on the path that is triggered in this crash, we do not need to go through a stack cookie check. This can hopefully fix this crash, but if the two products are incompatible then a new crash may appear.
The variables that result in generating the stack cookie checks are `mbi` and `sectionFileName`. The proposed patch moves them to a helper function, so that on the path that is triggered in this crash, we do not need to go through a stack cookie check (coincidentally, this may result in a small performance optimization since we will sometimes avoid unnecessary calls to `NtQueryVirtualMemory`). This can hopefully fix this crash, but if the two products are incompatible then a new crash may appear.
The variables that result in generating the stack cookie checks are `mbi` and `sectionFileName`. The proposed patch moves them to a helper function, so that on the path that is triggered in this crash, we do not need to go through a stack cookie check (coincidentally, this may result in a small performance boost since we will sometimes avoid unnecessary calls to `NtQueryVirtualMemory`). This can hopefully fix this crash, but if the two products are incompatible then a new crash may appear.
The variables that result in generating the stack cookie checks are `mbi` and `sectionFileName`. The proposed patch moves them to a helper function, so that on the path that is triggered in this crash, we do not need to go through a stack cookie check (coincidentally, this may result in a small performance boost since we will sometimes avoid unnecessary calls to `NtQueryVirtualMemory`). This can hopefully fix this crash, but if the two products are incompatible then a new, different crash may appear.

Back to Bug 1733532 Comment 5