Bug 1735076 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Wayne Mery (:wsmwk) from comment #1)
> Indeed, tab works, arrow does not.
> Thomas, is this by design?

Hell no! And it's much worse and more cunning than described: The cursor keys *are* functional, but there's zero visible indication that the focus has moved to another button. So if for whatever reason I change my mind and want to save the message anyway, invisible focus from arrow keys might be on `Discard...`, and `Enter` will discard, but `Save` is the only button showing blue. Maybe it's this modern thing of showing focus ring only when keyboard is used, which fails to kick in here. `Tab` shows the correct behaviour.

Alex, can you make a plan or otherwise ask someone else?
This is basic functionality seriously broken for keyboard use, and with unexpected danger of dataloss. Maybe a toolkit thing, so probably affects other dialogs, too.
Richard, any insights?

STR

1. compose msg
2. close msg (Alt+F4, or [x] button)
3. On `Save message` dialog, press `arrow right` exactly one time (sic! ignore that there's no visual feedback per this bug!)
4. Press `Enter`

Actual

- After step 3, focus has correctly moved to `Discard...` button, but there's zero indication of the focus change, so only `Save` default button looks focused
- Ater step 4, `Discard...` button is unexpectedly triggered even though it did not have any visible indication of focus, and I actually wanted `Save`!
- Dataloss! Message discarded against my will.
- Using arrow keys is now Russian roulette as user will never see which button really has focus.

Expected

- Using arrow keys must show and move the focus ring on buttons, not just move the focus without visible indication
- prevent unexpected dataloss and random unpredictable behaviour
(In reply to Wayne Mery (:wsmwk) from comment #1)
> Indeed, tab works, arrow does not.
> Thomas, is this by design?

Hell no! And it's much worse and more cunning than described: The cursor keys *are* functional, but there's zero visible indication that the focus has moved to another button. So if for whatever reason I change my mind and want to save the message anyway, invisible focus from arrow keys might be on `Discard...`, and `Enter` will discard, but `Save` is the only button showing blue. Maybe it's this modern thing of showing focus ring only when keyboard is used, which fails to kick in here. `Tab` shows the correct behaviour.

This is basic functionality seriously broken for keyboard use, and with unexpected danger of dataloss. Maybe a toolkit thing, so probably affects other dialogs, too.

Alex, can you make a plan or otherwise ask someone else?
Richard, any insights?

STR

1. compose msg
2. close msg (Alt+F4, or [x] button)
3. On `Save message` dialog, press `arrow right` exactly one time (sic! ignore that there's no visual feedback per this bug!)
4. Press `Enter`

Actual

- After step 3, focus has correctly moved to `Discard...` button, but there's zero indication of the focus change, so only `Save` default button looks focused
- Ater step 4, `Discard...` button is unexpectedly triggered even though it did not have any visible indication of focus, and I actually wanted `Save`!
- Dataloss! Message discarded against my will.
- Using arrow keys is now Russian roulette as user will never see which button really has focus.

Expected

- Using arrow keys must show and move the focus ring on buttons, not just move the focus without visible indication
- prevent unexpected dataloss and random unpredictable behaviour
(In reply to Wayne Mery (:wsmwk) from comment #1)
> Indeed, tab works, arrow does not.
> Thomas, is this by design?

Hell no! And it's much worse and more cunning than described: The cursor keys *are* functional, but there's zero visible indication that the focus has moved to another button. So if for whatever reason I change my mind and want to save the message anyway, invisible focus from arrow keys might be on `Discard...`, and `Enter` will discard, but `Save` is the only button showing blue. Maybe it's this modern thing of showing focus ring only when keyboard is used, which fails to kick in here. `Tab` shows the correct behaviour.

This is basic functionality seriously broken for keyboard use, and with unexpected danger of dataloss. Maybe a toolkit thing, so probably affects other dialogs, too.

Alex, can you make a plan or otherwise ask someone else?
Richard, any insights?

STR (on Windows 10, 91.4.0 (64-bit))

1. compose msg
2. close msg (Alt+F4, or [x] button)
3. On `Save message` dialog, press `arrow right` exactly one time (sic! ignore that there's no visual feedback per this bug!)
  This assumes the button sequence on Windows: `Save`, `Discard changes`, `Cancel`. Your OS might have different order, or bug may not occur on other OS.
4. Press `Enter`

Actual

- After step 3, focus has correctly moved to `Discard...` button, but there's zero indication of the focus change, so only `Save` default button looks focused
- Ater step 4, `Discard...` button is unexpectedly triggered even though it did not have any visible indication of focus, and I actually wanted `Save`!
- Dataloss! Message discarded against my will.
- Using arrow keys is now Russian roulette as user will never see which button really has focus.

Expected

- Using arrow keys must show and move the focus ring on buttons, not just move the focus without visible indication
- prevent unexpected dataloss and random unpredictable behaviour
(In reply to Wayne Mery (:wsmwk) from comment #1)
> Indeed, tab works, arrow does not.
> Thomas, is this by design?

Hell no! And it's much worse and more cunning than described: The cursor keys *are* functional, but there's zero visible indication that the focus has moved to another button. So if for whatever reason I change my mind and want to save the message anyway, invisible focus from arrow keys might be on `Discard...`, and `Enter` will discard, but `Save` is the only button showing blue. Maybe it's this modern thing of showing focus ring only when keyboard is used, which fails to kick in here. `Tab` shows the correct behaviour.

This is basic functionality seriously broken for keyboard use, and with unexpected danger of dataloss. Maybe a toolkit thing, so probably affects other dialogs, too.

Alex, can you make a plan or otherwise ask someone else?
Richard, any insights?

STR (on Windows 10, 91.4.0 (64-bit))

1. compose msg
2. close msg (Alt+F4, or [x] button)
3. On `Save message` dialog, press `arrow right` exactly one time (sic! Ignore that there's no visual feedback per this bug! Do not press `Tab` before you press arrows)
  This assumes the button sequence on Windows: `Save`, `Discard changes`, `Cancel`. Your OS might have different order, or bug may not occur on other OS.
4. Press `Enter`

Actual

- After step 3, focus has correctly moved to `Discard...` button, but there's zero indication of the focus change, so only `Save` default button looks focused
- Ater step 4, `Discard...` button is unexpectedly triggered even though it did not have any visible indication of focus, and I actually wanted `Save`!
- Dataloss! Message discarded against my will.
- Using arrow keys is now Russian roulette as user will never see which button really has focus.

Expected

- Using arrow keys must show and move the focus ring on buttons, not just move the focus without visible indication
- prevent unexpected dataloss and random unpredictable behaviour

Back to Bug 1735076 Comment 2