Bug 1736245 Comment 20 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Gnome X11, Ubuntu 23.04 LTS, Nvidia GTX1060:
Manually enabled FXAA in Nvidia Settings > X Screen 0 > Antialiasing Settings.

bug 1714483 meant: 
GLX=almost white window.
EGL=blurry text.

Old builds from before bug 1714483 comment 35 still behave the same:
* GLX white window: MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --launch 2021-09-01
* EGL blurry text: MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --launch 2021-09-16 
* GLX white window: old 78.14.0esr https://archive.torproject.org/tor-package-archive/torbrowser/10.5.6/tor-browser-linux64-10.5.6_en-US.tar.xz with gfx.webrender.all=true

Today:
* Chromium is unaffected.
* __GL_ALLOW_FXAA_USAGE=0 is hardcoded in Gecko
* There are 3 firefox rules in /usr/share/nvidia/nvidia-application-profiles-530.41.03-rc, but none for thunderbird, tor-browser, other firefox forks.

Weighting of interests:
getenv startup crash(bug 1794309 "Nvidia/Linux: Crash in [@ getenv]"/bug 1784813)&possible security problems
vs.
self-inflicted glitch.

(Darkspirit from bug 1794309 comment #4)
> I'm not really a programmer, but I assume this could be related to bug 1784813 and it could be worth a try
> * to remove this code:
>   https://searchfox.org/mozilla-central/rev/a4a41aafa80bf38f6e456238a60781fed46f9d08/gfx/thebes/gfxPlatformGtk.cpp#129-132
>   > // Bug 1714483: Force disable FXAA Antialiasing on NV drivers. This is a
>   > // temporary workaround for a driver bug.
>   > PR_SetEnv("__GL_ALLOW_FXAA_USAGE=0");
>   
>   * This code is to prevent massive glitches caused by manually enabling FXAA in Nvidia settings. It's the user's own fault.
>   * bug 1714483 comment 37: Nvidia has added a blocklist rule for Firefox in their driver, so that users can't manually enable it, but it likely wouldn't apply to Thunderbird, etc.
> 
> * at least to restrict this to isMesa:
>   https://searchfox.org/mozilla-central/rev/a4a41aafa80bf38f6e456238a60781fed46f9d08/gfx/thebes/gfxPlatformGtk.cpp#174-177
>   > if (feature.IsEnabled() && IsX11Display()) {
>   >   // Enabling glthread crashes on X11/EGL, see bug 1670545
>   >   PR_SetEnv("mesa_glthread=false");
>   > }
>   * This code is to prevent a crash caused by manually setting mesa_glthread=true environment variable. It's the user's own fault.

Thanks to the EGL/Nvidia rollout and moving older drivers to SW WR,  affected users only get blurry text.
Can you add an isMesa check to mesa_glthread=false and remove __GL_ALLOW_FXAA_USAGE=0?
Gnome X11, Ubuntu 22.04.2 LTS, Nvidia GTX1060:
Manually enabled FXAA in Nvidia Settings > X Screen 0 > Antialiasing Settings.

bug 1714483 meant: 
GLX=almost white window.
EGL=blurry text.

Old builds from before bug 1714483 comment 35 still behave the same:
* GLX white window: MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --launch 2021-09-01
* EGL blurry text: MOZ_DISABLE_CONTENT_SANDBOX=1 mozregression --launch 2021-09-16 
* GLX white window: old 78.14.0esr https://archive.torproject.org/tor-package-archive/torbrowser/10.5.6/tor-browser-linux64-10.5.6_en-US.tar.xz with gfx.webrender.all=true

Today:
* Chromium is unaffected.
* __GL_ALLOW_FXAA_USAGE=0 is hardcoded in Gecko
* There are 3 firefox rules in /usr/share/nvidia/nvidia-application-profiles-530.41.03-rc, but none for thunderbird, tor-browser, other firefox forks.

Weighting of interests:
getenv startup crash(bug 1794309 "Nvidia/Linux: Crash in [@ getenv]"/bug 1784813)&possible security problems
vs.
self-inflicted glitch.

(Darkspirit from bug 1794309 comment #4)
> I'm not really a programmer, but I assume this could be related to bug 1784813 and it could be worth a try
> * to remove this code:
>   https://searchfox.org/mozilla-central/rev/a4a41aafa80bf38f6e456238a60781fed46f9d08/gfx/thebes/gfxPlatformGtk.cpp#129-132
>   > // Bug 1714483: Force disable FXAA Antialiasing on NV drivers. This is a
>   > // temporary workaround for a driver bug.
>   > PR_SetEnv("__GL_ALLOW_FXAA_USAGE=0");
>   
>   * This code is to prevent massive glitches caused by manually enabling FXAA in Nvidia settings. It's the user's own fault.
>   * bug 1714483 comment 37: Nvidia has added a blocklist rule for Firefox in their driver, so that users can't manually enable it, but it likely wouldn't apply to Thunderbird, etc.
> 
> * at least to restrict this to isMesa:
>   https://searchfox.org/mozilla-central/rev/a4a41aafa80bf38f6e456238a60781fed46f9d08/gfx/thebes/gfxPlatformGtk.cpp#174-177
>   > if (feature.IsEnabled() && IsX11Display()) {
>   >   // Enabling glthread crashes on X11/EGL, see bug 1670545
>   >   PR_SetEnv("mesa_glthread=false");
>   > }
>   * This code is to prevent a crash caused by manually setting mesa_glthread=true environment variable. It's the user's own fault.

Thanks to the EGL/Nvidia rollout and moving older drivers to SW WR,  affected users only get blurry text.
Can you add an isMesa check to mesa_glthread=false and remove __GL_ALLOW_FXAA_USAGE=0?

Back to Bug 1736245 Comment 20