Bug 1738848 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

ADing, looks like you have a separate issue preventing you from doing a `./mach create-mach-environment` successfully. Specifically:

> `ValueError: check_hostname requires server_hostname`

Have you configured a proxy? That seems to [be the cause of the issue](https://stackoverflow.com/questions/66642705/why-requests-raise-this-exception-check-hostname-requires-server-hostname). For example, do you have the `http_proxy` or `https_proxy` environment variable set? Can you share the results of the `env` command?

-----

Related: it's unclear why the recent changes are requiring a re-creation of the Mach virtualenv. Especially (and thanks for sharing this, James):

> What's weird is that before I did that, running the python in the venv and doing import zstandard wasn't failing!
ADing, looks like you have a separate issue preventing you from doing a `./mach create-mach-environment` successfully. Specifically:

> `ValueError: check_hostname requires server_hostname`

Have you configured a proxy? That seems to [be the cause of the issue](https://stackoverflow.com/questions/66642705/why-requests-raise-this-exception-check-hostname-requires-server-hostname). For example, do you have the `http_proxy` or `https_proxy` environment variable set? Can you share the results of the `env` command?

-----

Related: it's unclear why the recent changes are requiring a re-creation of the Mach virtualenv. Especially (and thanks for sharing this, James):

> What's weird is that before I did that, running the python in the venv and doing import zstandard wasn't failing!

I'm trying to reproduce locally here:
1. Clean checkout at `02ea2d15bf4c17c346aa9e06775c7027cdfacabf`, before the recent regressing landings
2. Purge `obj-*`, `~/.mozbuild/_virtualenvs`
3. `./mach bootstrap` with artifact extraction
4. Update to `0b166cabc98d7edf925b3d1dd000b59d4028752e`, after the regressing landings
5. `./mach bootstrap` with artifact extraction

I'm not getting the `zstandard` import error 😔
ADing, looks like you have a separate issue preventing you from doing a `./mach create-mach-environment` successfully. Specifically:

> `ValueError: check_hostname requires server_hostname`

Have you configured a proxy? That seems to [be the cause of the issue](https://stackoverflow.com/questions/66642705/why-requests-raise-this-exception-check-hostname-requires-server-hostname). For example, do you have the `http_proxy` or `https_proxy` environment variable set? Can you share the results of the `env` command?

-----

Related: it's unclear why the recent changes are requiring a re-creation of the Mach virtualenv. Especially (and thanks for sharing this, James):

> What's weird is that before I did that, running the python in the venv and doing import zstandard wasn't failing!

I'm trying to reproduce locally here:
1. Clean checkout at `02ea2d15bf4c17c346aa9e06775c7027cdfacabf`, before the recent regressing landings
2. Purge `obj-*`, `~/.mozbuild/_virtualenvs`
3. `./mach bootstrap` with artifact extraction
4. Update to `0b166cabc98d7edf925b3d1dd000b59d4028752e`, after the regressing landings
5. `./mach bootstrap` with artifact extraction

I'm not getting the `zstandard` import error 😔
EDIT: I have a home machine dev machine running Windows that I haven't updated to newer `m-c` in a while, I'll see if I can repro there to get to the root cause.

Back to Bug 1738848 Comment 7