Bug 1740534 Comment 24 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

:annevk and I reached clarity/consensus on the failing tests above.  The conclusions as I understand them are:
- Spec-wise, there is a gap in WebIDL's [Invoking Callback Functions] and this should be rectified after our fix here sufficiently lands.
  - Step 5 and 6 are appropriately retrieving the settings object from the callback, but the WebIDL spec is not calling [check if we can run script](https://html.spec.whatwg.org/multipage/webappapis.html#check-if-we-can-run-script) as part of/prelude to step 11, even though [prepare to run script](https://html.spec.whatwg.org/multipage/webappapis.html#prepare-to-run-script) is correctly being called with the right settings object in step 8.
- Both of the tests that failed above are in fact depending on the ability to call into script when [check if we can run a script](https://html.spec.whatwg.org/multipage/webappapis.html#check-if-we-can-run-script) would return "do not run" because the detached iframe is not fully active.  And so it's reasonable for us to appropriately disable the tests, in this case removing the incorrect mochitest and marking the WPT test as an expected failure, with plans to correct the WPT test as part of the spec-work.
- When addressing the spec issues, we'll also make sure to ensure WPT coverage for these changes, with both of these tests providing good insight to examples of how this might be tested!

I'm clearing the needinfo on :smaug because I think I have all the answers necessary here.

I'll post an attachment in a second that's a revised version of the mochitest that I used for exploration when talking to Anne.
:annevk and I reached clarity/consensus on the failing tests above.  The conclusions as I understand them are:
- Spec-wise, there is a gap in WebIDL's [Invoking Callback Functions](https://webidl.spec.whatwg.org/#es-invoking-callback-functions) and this should be rectified after our fix here sufficiently lands.
  - Step 5 and 6 are appropriately retrieving the settings object from the callback, but the WebIDL spec is not calling [check if we can run script](https://html.spec.whatwg.org/multipage/webappapis.html#check-if-we-can-run-script) as part of/prelude to step 11, even though [prepare to run script](https://html.spec.whatwg.org/multipage/webappapis.html#prepare-to-run-script) is correctly being called with the right settings object in step 8.
- Both of the tests that failed above are in fact depending on the ability to call into script when [check if we can run a script](https://html.spec.whatwg.org/multipage/webappapis.html#check-if-we-can-run-script) would return "do not run" because the detached iframe is not fully active.  And so it's reasonable for us to appropriately disable the tests, in this case removing the incorrect mochitest and marking the WPT test as an expected failure, with plans to correct the WPT test as part of the spec-work.
- When addressing the spec issues, we'll also make sure to ensure WPT coverage for these changes, with both of these tests providing good insight to examples of how this might be tested!

I'm clearing the needinfo on :smaug because I think I have all the answers necessary here.

I'll post an attachment in a second that's a revised version of the mochitest that I used for exploration when talking to Anne.

Back to Bug 1740534 Comment 24