Bug 1740889 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

For the records: [Here we have](https://crash-stats.mozilla.org/report/index/398a44a6-442d-40b7-8349-803240211112) a real SpinEventLoopUntil case, but the call is inlined:

```
 	ntdll.dll!NtWaitForAlertByThreadId()	Unbekannt
 	ntdll.dll!RtlSleepConditionVariableSRW()	Unbekannt
 	KERNELBASE.dll!SleepConditionVariableSRW()	Unbekannt
	mozglue.dll!mozilla::detail::ConditionVariableImpl::wait(mozilla::detail::MutexImpl & lock) Zeile 50	C++
 	[Inlineframe] xul.dll!mozilla::OffTheBooksCondVar::Wait() Zeile 58	C++
 	xul.dll!mozilla::ThreadEventQueue::GetEvent(bool aMayWait, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> * aLastEventDelay) Zeile 171	C++
 	xul.dll!nsThread::ProcessNextEvent(bool aMayWait, bool * aResult) Zeile 1050	C++
 	xul.dll!NS_ProcessNextEvent(nsIThread * aThread, bool aMayWait) Zeile 467	C++
> 	[Inlineframe] xul.dll!mozilla::SpinEventLoopUntil(const nsTSubstring<char> & aVeryGoodReasonToDoThis, mozilla::dom::`anonymous namespace'::RequestHelper::StartAndReturnResponse::<lambda_58> && aPredicate, nsIThread * aThread) Zeile 176	C++
 	[Inlineframe] xul.dll!mozilla::dom::`anonymous namespace'::RequestHelper::StartAndReturnResponse(mozilla::dom::LSRequestResponse & aResponse) Zeile 1222	C++
 	xul.dll!mozilla::dom::LSObject::DoRequestSynchronously(const mozilla::dom::LSRequestParams & aParams, mozilla::dom::LSRequestResponse & aResponse) Zeile 886	C++
 	xul.dll!mozilla::dom::LSObject::EnsureDatabase() Zeile 938	C++
 	xul.dll!mozilla::dom::LSObject::SetItem(const nsTSubstring<char16_t> & aKey, const nsTSubstring<char16_t> & aValue, nsIPrincipal & aSubjectPrincipal, mozilla::ErrorResult & aError) Zeile 684	C++
 	xul.dll!mozilla::dom::Storage_Binding::setItem(JSContext * cx, JS::Handle<JSObject *> obj, void * void_self, const JSJitMethodCallArgs & args) Zeile 233	C++
 	xul.dll!mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext * cx, unsigned int argc, JS::Value * vp) Zeile 3300	C++

```
For the records and as an opposite case to bug 1741131: [Here we have](https://crash-stats.mozilla.org/report/index/398a44a6-442d-40b7-8349-803240211112) a real SpinEventLoopUntil case, but the call is inlined:

```
 	ntdll.dll!NtWaitForAlertByThreadId()	Unbekannt
 	ntdll.dll!RtlSleepConditionVariableSRW()	Unbekannt
 	KERNELBASE.dll!SleepConditionVariableSRW()	Unbekannt
	mozglue.dll!mozilla::detail::ConditionVariableImpl::wait(mozilla::detail::MutexImpl & lock) Zeile 50	C++
 	[Inlineframe] xul.dll!mozilla::OffTheBooksCondVar::Wait() Zeile 58	C++
 	xul.dll!mozilla::ThreadEventQueue::GetEvent(bool aMayWait, mozilla::BaseTimeDuration<mozilla::TimeDurationValueCalculator> * aLastEventDelay) Zeile 171	C++
 	xul.dll!nsThread::ProcessNextEvent(bool aMayWait, bool * aResult) Zeile 1050	C++
 	xul.dll!NS_ProcessNextEvent(nsIThread * aThread, bool aMayWait) Zeile 467	C++
> 	[Inlineframe] xul.dll!mozilla::SpinEventLoopUntil(const nsTSubstring<char> & aVeryGoodReasonToDoThis, mozilla::dom::`anonymous namespace'::RequestHelper::StartAndReturnResponse::<lambda_58> && aPredicate, nsIThread * aThread) Zeile 176	C++
 	[Inlineframe] xul.dll!mozilla::dom::`anonymous namespace'::RequestHelper::StartAndReturnResponse(mozilla::dom::LSRequestResponse & aResponse) Zeile 1222	C++
 	xul.dll!mozilla::dom::LSObject::DoRequestSynchronously(const mozilla::dom::LSRequestParams & aParams, mozilla::dom::LSRequestResponse & aResponse) Zeile 886	C++
 	xul.dll!mozilla::dom::LSObject::EnsureDatabase() Zeile 938	C++
 	xul.dll!mozilla::dom::LSObject::SetItem(const nsTSubstring<char16_t> & aKey, const nsTSubstring<char16_t> & aValue, nsIPrincipal & aSubjectPrincipal, mozilla::ErrorResult & aError) Zeile 684	C++
 	xul.dll!mozilla::dom::Storage_Binding::setItem(JSContext * cx, JS::Handle<JSObject *> obj, void * void_self, const JSJitMethodCallArgs & args) Zeile 233	C++
 	xul.dll!mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy,mozilla::dom::binding_detail::ThrowExceptions>(JSContext * cx, unsigned int argc, JS::Value * vp) Zeile 3300	C++

```

Back to Bug 1740889 Comment 1