I'm intending to land later today. Will need documentation change at `proxyDNS` https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings#proxydns Current string: "Proxy DNS when using SOCKS5. Defaults to `false`." This is wrong, correct would be "Proxy DNS when using SOCKS4 or SOCKS5. Defaults to `false`." With this patch it should change. Suggested documentation: "Proxy DNS when using a SOCKS proxy. Defaults to `true` when using SOCKS5, defaults to `false` when using SOCKS4."
Bug 1741375 Comment 32 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm intending to land later today. Will need documentation change at `proxyDNS` https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings#proxydns Current string: "Proxy DNS when using SOCKS5. Defaults to `false`." This is wrong, correct would be "Proxy DNS when using SOCKS4 or SOCKS5. Defaults to `false`." With this patch it needs to change further. Suggested documentation: "Proxy DNS when using a SOCKS proxy. Defaults to `true` when using SOCKS5, defaults to `false` when using SOCKS4."
I'm intending to land ~~later today~~ (Edit: next week. Will need to address conflict with [D209875](https://phabricator.services.mozilla.com/D209875), will rebase after it is in m-c). Will need documentation change at `proxyDNS` https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings#proxydns Current string: "Proxy DNS when using SOCKS5. Defaults to `false`." This is wrong, correct would be "Proxy DNS when using SOCKS4 or SOCKS5. Defaults to `false`." With this patch it needs to change further. Suggested documentation: "Proxy DNS when using a SOCKS proxy. Defaults to `true` when using SOCKS5, defaults to `false` when using SOCKS4."