Bug 1741795 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Punam Dahiya [:pdahiya] from comment #4)
> Hi Hector , quick question, is there a pref thats configured in partner builds and should be read to pick mobile link (www.firefox.com.cn) or should we create one . Please feel free to suggest if there is a better approach to fix this issue Thanks!

Hi Punam,

In my opinion, the optimal way would actually be including our URL directly in m-c directly and use it when `distribution.id` is set to `MozillaOnline` on default branch, which is the most reliable way to detect our repack. This also makes the way that we're customizing it more visible. The shortcoming is this won't scale if other partners want this too.

Alternatively and more generic, we could agree on a pref key and then override it in our repack. However overriding it in the [distribution.ini](https://wiki.mozilla.org/Distribution_INI_File) file would only works for new profiles, and we'll have to override it with our extension for existing profiles, which could be later uninstalled by an user or disabled by incidents like armagadd-on-2.0 (bug 1548973).

An existing pref we're already overriding is `browser.contentblocking.report.mobile-android.url`, but its name is very specific.

I hope this is helpful.
(In reply to Punam Dahiya [:pdahiya] from comment #4)
> Hi Hector , quick question, is there a pref thats configured in partner builds and should be read to pick mobile link (www.firefox.com.cn) or should we create one . Please feel free to suggest if there is a better approach to fix this issue Thanks!

Hi Punam,

In my opinion, the optimal way would actually be including our URL in m-c directly and use it when `distribution.id` is set to `MozillaOnline` on default branch, which is the most reliable way to detect our repack. This also makes the way that we're customizing it more visible. The shortcoming is this won't scale if other partners want this too.

Alternatively and more generic, we could agree on a pref key and then override it in our repack. However overriding it in the [distribution.ini](https://wiki.mozilla.org/Distribution_INI_File) file would only works for new profiles, and we'll have to override it with our extension for existing profiles, which could be later uninstalled by an user or disabled by incidents like armagadd-on-2.0 (bug 1548973).

An existing pref we're already overriding is `browser.contentblocking.report.mobile-android.url`, but its name is very specific.

I hope this is helpful.

Back to Bug 1741795 Comment 5