+++ This bug was initially created as a clone of Bug #620853 +++ `Thunderbird`: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd+Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, the prompt's default button will also trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold Ctrl+Enter for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, Ctrl+Enter. This is unexpected and self-defeats the purpose of the prompt. Expected Results: - Dialog prompt should ignore Ctrl+Enter and remain open.
Bug 1742707 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
+++ This bug was initially created as a clone of `Thunderbird` Bug #620853: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt +++ ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd+Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, the prompt's default button will also trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold `Ctrl+Enter` for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, `Ctrl+Enter`. This is unexpected and self-defeats the purpose of the prompt. Expected Results: - Dialog prompt should ignore `Ctrl+Enter` and remain open until confirmed with plain `Enter`
+++ This bug was initially created as a clone of `Thunderbird` Bug #620853: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt +++ ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd + Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, the prompt's default button will also trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold `Ctrl+Enter` for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, `Ctrl+Enter`. This is unexpected and self-defeats the purpose of the prompt. Expected Results: - Dialog prompt should ignore `Ctrl+Enter` and remain open until confirmed with plain `Enter`
+++ This bug was initially created as a clone of `Thunderbird` Bug #620853: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt +++ ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd + Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient, expected and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, the prompt's default button will also trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold `Ctrl+Enter` for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, `Ctrl+Enter`. This is unexpected and self-defeats the purpose of the prompt. Expected Results: - Dialog prompt should ignore `Ctrl+Enter` and remain open until confirmed with plain `Enter`
+++ This bug was initially created as a clone of `Thunderbird` Bug #620853: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt +++ ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd + Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient, expected and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, the prompt's default button will also trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold `Ctrl+Enter` for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, `Ctrl+Enter`. This is unexpected and self-defeats the purpose of the prompt. Also sends multiple copies of the message as long as you keep holding Ctrl+Enter. Expected Results: - Dialog prompt should ignore `Ctrl+Enter` and remain open until confirmed with plain `Enter`
+++ This bug was initially created as a clone of `Thunderbird` Bug #620853: Holding Ctrl+Enter a little too long can cause unintentional confirmation of "Send Message?" warning popup - only plain Enter (without modifier key) should confirm the prompt +++ ----------- STR - On any dialog provided by the toolkit widget and having a default button, press `Ctrl/Alt/Shift/Cmd + Enter` Actual - default button gets triggered although `Enter` keypress was modified Expected - default button should only get triggered for plain `Enter` keypress, i.e. only when no modifier keys are pressed. For these simple out-of-the-box dialogs, it's neither feasible nor possible to change button action based on modifier key, so imo checking exactly for plain `Enter` should be sufficient, expected and correct. ----------- Thunderbird use case Ctrl+Enter is Thunderbird shortcut for `Send message now` and comes with a confirmation prompt to prevent accidentally sending a message. However, due to this bug, the prompt's default button will *also* trigger on Ctrl+Enter, which is self-defeating and makes the prompt a no-op. STR 1. Compose a message 2. Hold `Ctrl+Enter` for a second or two Actual Results: - `Send message?` confirmation prompt is immediately confirmed by the same keyboard shortcut which brought it up, `Ctrl+Enter`. This is unexpected and self-defeats the purpose of the prompt. Also sends multiple copies of the message as long as you keep holding Ctrl+Enter. Expected Results: - Dialog prompt should ignore `Ctrl+Enter` and remain open until confirmed with plain `Enter`