I guess it's all fallout essentially from bug 1547096. There's just too much junk in GuessConfig.jsm, so really hard to reason with it. Anyway, seems get don't get an error status for bad cert at https://searchfox.org/comm-central/rev/fbd21ecf0fd7cc799d1021dc1bb238edb380bcbe/mail/components/accountcreation/GuessConfig.jsm#1221 so a lot of this code is very likely dead. We really should rewrite it to using TCPSocket instead. > Is this still necessary? Probably not, during verifyConfig you do get notified anyway and will have to accept the cert override to continue. > is this string accurate? Sure. Maybe "Warning! Bad certificate. Could not verify server" would be better... > Is this warning related to the whole server or only to a specific protocol? To the specific configuration (hostname+port) - whatever we got back from that. (In practice, cert will cover the whole hostname at least) > If this is necessary and we need to reintroduce it, we should improve the string and add a better explanation. The popup one does get during verifyConfig has the more detailed explanation.
Bug 1744319 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I guess it's all fallout essentially from bug 1547096. There's just too much junk in GuessConfig.jsm, so really hard to reason with it. Anyway, seems we don't get an error status for bad cert at https://searchfox.org/comm-central/rev/fbd21ecf0fd7cc799d1021dc1bb238edb380bcbe/mail/components/accountcreation/GuessConfig.jsm#1221 so a lot of this code is very likely dead. We really should rewrite it to using TCPSocket instead. > Is this still necessary? Probably not, during verifyConfig you do get notified anyway and will have to accept the cert override to continue. > is this string accurate? Sure. Maybe "Warning! Bad certificate. Could not verify server" would be better... > Is this warning related to the whole server or only to a specific protocol? To the specific configuration (hostname+port) - whatever we got back from that. (In practice, cert will cover the whole hostname at least) > If this is necessary and we need to reintroduce it, we should improve the string and add a better explanation. The popup one does get during verifyConfig has the more detailed explanation.