Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py`. Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!
Bug 1744340 Comment 9 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py`. Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * ... with `colorama` usage as I described above. * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!
Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py`. Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * with `colorama` usage as I described above. * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!
Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py` and hopefully also in `machformatter.py`. Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * with `colorama` usage as I described above. * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!
Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py` and hopefully also in `machformatter.py` (via mozterm). Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * with `colorama` usage as I described above. * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!
Hi Alex, based on my findings, do you want to retry with latest MSYS bits? What I did: 1. Replace `mozilla-build/msys2` with the latest MSYS2 installation (because `pacman -Suy` failed on bundled msys2) 2. Run `pacman -Suy`. (It requires restarting the terminal after updating core modules, so you need to run it twice) 3. Run `pacman -S m4 diffutils` for missing dependencies 4. Apply your patch, except the greedy `enable_virtual_terminal_processing()`. This is nowhere needed! One problem is that [`blessings` is not Windows compatible at all](https://github.com/erikrose/blessings/issues/21) because of `curse` and `fcntl` dependency. We fortunately already have `colorama` and it provides sufficient features to replace `blessings` at least in `logging.py` and hopefully also in `machformatter.py` (via `mozterm/terminal.py`). Then we can probably use `StructuredTerminalFormatter` for Windows too. So I think the work item here is: 1. Get a new MozillaBuild release (solely because of pacman failure. Can we do the pacman update as a mach command btw?) 2. Apply your patch! * with `colorama` usage as I described above. * Probably need to keep backward compatibility with older MozillaBuild for some time. Checking `ENABLE_VIRTUAL_TERMINAL_PROCESSING` should be sufficient I guess. I can also try at least the python side if you have no time right now, just say it!