Bug 1744340 Comment 23 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I figured it out. 

My old patch was unreachable code on the up-to-date `central`, so it wasn't enabling color for `clang-cl`.

old:
```
    elif info.type == "clang":
        return "-fcolor-diagnostics"
    elif info.type == "clang-cl":
        return "-fcolor-diagnostics -fansi-escape-codes"
    else:
        return ""
```
What I had:
```
    elif info.type in ["clang", "clang-cl"]:
        return "-fcolor-diagnostics"
    elif info.type == "clang-cl":
        return "-fcolor-diagnostics -fansi-escape-codes"
    else:
        return ""
```

Everything looks good and as I expected now. Thanks!
Revision 1 by
on 
I figured it out. 

My old patch was unreachable code on the up-to-date `central`, so it wasn't enabling color for `clang-cl`.

old:
```
    elif info.type == "clang":
        return "-fcolor-diagnostics"
    elif info.type == "clang-cl":
        return "-fcolor-diagnostics -fansi-escape-codes"
    else:
        return ""
```
What I had (mix of my old patch + current central):
```
    elif info.type in ["clang", "clang-cl"]:
        return "-fcolor-diagnostics"
    elif info.type == "clang-cl":
        return "-fcolor-diagnostics -fansi-escape-codes"
    else:
        return ""
```

Everything looks good and as I expected now. Thanks!

Back to Bug 1744340 Comment 23